Re: [v5 PATCH] wmvcore/tests: add tests for WMReader methods
Jefferson Carpenter <jeffersoncarpenter2(a)gmail.com> writes:
Can somebody explain why this one wasn't committed?
I'm not convinced we need a large binary file for this, and it also seems to take a long time to run mainly because it's just a bunch of timeouts at this point. I'd like to see the implementation being fleshed out a bit first. -- Alexandre Julliard julliard(a)winehq.org
Without a large binary file, how would we test the successful processing of an audio or video file? We could use an IWMWriter to create it, but then we wouldn't be testing for conformance against the Windows API. On Mon, Sep 4, 2017 at 4:22 AM, Alexandre Julliard <julliard(a)winehq.org> wrote:
Jefferson Carpenter <jeffersoncarpenter2(a)gmail.com> writes:
Can somebody explain why this one wasn't committed?
I'm not convinced we need a large binary file for this, and it also seems to take a long time to run mainly because it's just a bunch of timeouts at this point. I'd like to see the implementation being fleshed out a bit first.
-- Alexandre Julliard julliard(a)winehq.org
Jefferson Carpenter <jeffersoncarpenter2(a)gmail.com> writes:
Without a large binary file, how would we test the successful processing of an audio or video file? We could use an IWMWriter to create it, but then we wouldn't be testing for conformance against the Windows API.
In general, to test something like a file loader, you'd want to test multiple files with various contents, including invalid values for header fields and the like. This is better done by generating them instead of including pre-built binaries. Like you said, using IWMWriter wouldn't guarantee that we are testing the right thing, so we'd most likely want to generate them by hand somehow. Again, this would be better done along with the implementation, so we can get a better idea of what cases would be interesting to test. -- Alexandre Julliard julliard(a)winehq.org
Okay, that makes sense. For the implementation, should libav be used, or ought wine to have its own implementation of the codecs? On Tue, Sep 5, 2017 at 1:43 PM, Alexandre Julliard <julliard(a)winehq.org> wrote:
Jefferson Carpenter <jeffersoncarpenter2(a)gmail.com> writes:
Without a large binary file, how would we test the successful processing of an audio or video file? We could use an IWMWriter to create it, but then we wouldn't be testing for conformance against the Windows API.
In general, to test something like a file loader, you'd want to test multiple files with various contents, including invalid values for header fields and the like. This is better done by generating them instead of including pre-built binaries. Like you said, using IWMWriter wouldn't guarantee that we are testing the right thing, so we'd most likely want to generate them by hand somehow.
Again, this would be better done along with the implementation, so we can get a better idea of what cases would be interesting to test.
-- Alexandre Julliard julliard(a)winehq.org
participants (2)
-
Alexandre Julliard -
Jefferson Carpenter