Re: [v9 01/11] ddraw: Check if surface is a mipmap sublevel or a non-positive X top level surface through caps in ddraw_surface7_GetPriority().

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi,

Am 2015-11-19 um 20:34 schrieb Riccardo Bortolato:
> -    else if (!(surface->surface_desc.ddsCaps.dwCaps2 & managed) || !surface->wined3d_texture)
> +    else if (!(surface->surface_desc.ddsCaps.dwCaps2 & managed)
> +            || (surface->surface_desc.ddsCaps.dwCaps2 & DDSCAPS2_MIPMAPSUBLEVEL)
> +            || ((surface->surface_desc.ddsCaps.dwCaps2 & DDSCAPS2_CUBEMAP)
> +                    && !(surface->surface_desc.ddsCaps.dwCaps2 & DDSCAPS2_CUBEMAP_POSITIVEX)))
> The patch and test looks good to me (and passes), but I don't think it's
> something we want to apply during the code freeze because it doesn't fix
> an actual bug by itself.

This applies to the general series, but you're welcome to resend it with
fixes, then we can pick it up after the release.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWUQ2iAAoJEN0/YqbEcdMwXK0P/jeYTfGSWQ6SFsi9+dnpepW7
UPAP3XnMG1M8wWRA81UjPWKGO/yzIUS9u9eqU6lgA4eZxtTlNbWoOK4iuXqBH9uP
c9K8s+ccP9phx/DIXdGed8l20z2UmEaRdOWYw/w75g2+Du62tJ9XZNPzRsuus8BP
1OJWe93/bS7PdFI2BxnoX+JLZ6SJ1ly0VLhav1o4KdymVfg+NbyBn5nYgOOrpzab
cmAuVNOlL+TCgTCMwVXihM/OThCh9OAAZSFi6NOT2SSVp+w8UUpVDlgzee3jRY6k
SvAwtSiblFfyzDcDR9XrFQmpaU/9QiifLJl37yTbKHwbZ9ZcxoA4tiHXGoei9dS+
sQCwWzlQxMSiESEVbNFCjev9r8BV9haTEA4zE1k5aEN/VORPzyD9acs6q8JhsuKv
+CchBOPSQ2kwK4egHTRB/5NmL8u0gAWIO37teeuZ0OMw64jYu9lmmHaRAWM5cmmV
D2pRI8bxbDUwSCA9D0DchkgGXTo1jsjKMhmf4VPJamfEMNiZstaTzg9KEqs/pNDm
SIerM7mv1hOumQPVRTGVlTSBcChItaq7ze5EpP0Xi9RdgrJ/OB6P+M2gn4nvuoPc
dFH7Nz+NAFCc1+YSagXATEfj83jNEvTczpOxBIBjepjoPRDKUknJbnCgnfCnb0fu
p6PXVd95kGGBDLpukVln
=7eyD
-----END PGP SIGNATURE-----

[v9 01/11] ddraw: Check if surface is a mipmap sublevel or a non-positive X top level surface through caps in ddraw_surface7_GetPriority().

[Riccardo Bortolato]

2015-11-22 1:34 GMT+01:00 Stefan Dösinger <stefandoesinger(a)gmail.com>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Hi,
>
> Am 2015-11-19 um 20:34 schrieb Riccardo Bortolato:
> > -    else if (!(surface->surface_desc.ddsCaps.dwCaps2 & managed) || !surface->wined3d_texture)
> > +    else if (!(surface->surface_desc.ddsCaps.dwCaps2 & managed)
> > +            || (surface->surface_desc.ddsCaps.dwCaps2 & DDSCAPS2_MIPMAPSUBLEVEL)
> > +            || ((surface->surface_desc.ddsCaps.dwCaps2 & DDSCAPS2_CUBEMAP)
> > +                    && !(surface->surface_desc.ddsCaps.dwCaps2 & DDSCAPS2_CUBEMAP_POSITIVEX)))
> > The patch and test looks good to me (and passes), but I don't think it's
> > something we want to apply during the code freeze because it doesn't fix
> > an actual bug by itself.

Hello Stefan,

it doesn't fix any bug that I know of (just like the rest of this
whole serie), but as you already know I cannot fix any bug that I care
of if I cannot get the whole cleanup serie in.

Ciao,
Riccardo
> This applies to the general series, but you're welcome to resend it with
> fixes, then we can pick it up after the release.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQIcBAEBCAAGBQJWUQ2iAAoJEN0/YqbEcdMwXK0P/jeYTfGSWQ6SFsi9+dnpepW7
> UPAP3XnMG1M8wWRA81UjPWKGO/yzIUS9u9eqU6lgA4eZxtTlNbWoOK4iuXqBH9uP
> c9K8s+ccP9phx/DIXdGed8l20z2UmEaRdOWYw/w75g2+Du62tJ9XZNPzRsuus8BP
> 1OJWe93/bS7PdFI2BxnoX+JLZ6SJ1ly0VLhav1o4KdymVfg+NbyBn5nYgOOrpzab
> cmAuVNOlL+TCgTCMwVXihM/OThCh9OAAZSFi6NOT2SSVp+w8UUpVDlgzee3jRY6k
> SvAwtSiblFfyzDcDR9XrFQmpaU/9QiifLJl37yTbKHwbZ9ZcxoA4tiHXGoei9dS+
> sQCwWzlQxMSiESEVbNFCjev9r8BV9haTEA4zE1k5aEN/VORPzyD9acs6q8JhsuKv
> +CchBOPSQ2kwK4egHTRB/5NmL8u0gAWIO37teeuZ0OMw64jYu9lmmHaRAWM5cmmV
> D2pRI8bxbDUwSCA9D0DchkgGXTo1jsjKMhmf4VPJamfEMNiZstaTzg9KEqs/pNDm
> SIerM7mv1hOumQPVRTGVlTSBcChItaq7ze5EpP0Xi9RdgrJ/OB6P+M2gn4nvuoPc
> dFH7Nz+NAFCc1+YSagXATEfj83jNEvTczpOxBIBjepjoPRDKUknJbnCgnfCnb0fu
> p6PXVd95kGGBDLpukVln
> =7eyD
> -----END PGP SIGNATURE-----