Re: Apparently it is possible to have chm file without #STRINGS in it, so we should not stop processing file at it. Fixes bug #12498

[Juan Lang]

> Have you tried patch without this "if"? In my case it crashes without it
>  when I try to open chm from bug #12498... i don't know if strdupW can
>  dup NULL as well as null?

Aaaah...  Sorry, my mistake, I missed this declaration:
        static const WCHAR null[] = {0};
That solves that mystery.

In that case, one fix per patch, please.  This fix and the other are
unrelated:  one fixes a crash, the other deals with a missing #STRINGS
stream.  Thanks,
--Juan

Apparently it is possible to have chm file without #STRINGS in it, so we should not stop processing file at it. Fixes bug #12498

[Tomasz Jezierski - Tefnet]

Dnia 15-04-2008, wto o godzinie 07:14 -0700, Juan Lang pisze:
> > Have you tried patch without this "if"? In my case it crashes
> > without it
> >  when I try to open chm from bug #12498... i don't know if strdupW
> > can
> >  dup NULL as well as null?
>
> Aaaah...  Sorry, my mistake, I missed this declaration:
>         static const WCHAR null[] = {0};
> That solves that mystery.
>
> In that case, one fix per patch, please.  This fix and the other are
> unrelated:  one fixes a crash, the other deals with a missing #STRINGS
> stream.  Thanks,

No, I think that crash is only possible with my patch. Right now if
there is no #STRINGS it closes chm and stops processing.

Apparently it is possible to have chm file without #STRINGS in it, so we should not stop processing file at it. Fixes bug #12498

[Hin-Tak Leung]

--- On Tue, 15/4/08, Juan Lang <juan.lang(a)gmail.com> wrote:
> From: Juan Lang <juan.lang(a)gmail.com>
> Subject: Re: Apparently it is possible to have chm file without #STRINGS in it, so we should not stop processing file at it. Fixes bug #12498
> To: "Tomasz Jezierski - Tefnet" <developers(a)tefnet.pl>
> Cc: "Wine Developers List" <wine-devel(a)winehq.org>
> Date: Tuesday, 15 April, 2008, 3:14 PM
> > Have you tried patch without this "if"? In
> > my case it crashes without it
> >  when I try to open chm from bug #12498... i don't
> > know if strdupW can
> >  dup NULL as well as null?
>
> Aaaah...  Sorry, my mistake, I missed this declaration:
>         static const WCHAR null[] = {0};
> That solves that mystery.
>
> In that case, one fix per patch, please.  This fix and the
> other are
> unrelated:  one fixes a crash, the other deals with a
> missing #STRINGS
> stream.  Thanks,
> --Juan

Hmm, sorry, it is probably not a good idea to name a variable "null" - 
it is just a little confusing. Maybe W_Null or even Wchar_Null or
to make it more obvious that it is a programmer-defined variable? 


      ___________________________________________________________ 
Yahoo! For Good helps you make a difference  

http://uk.promotions.yahoo.com/forgood/

Apparently it is possible to have chm file without #STRINGS in it, so we should not stop processing file at it. Fixes bug #12498

[Juan Lang]

> Hmm, sorry, it is probably not a good idea to name a variable "null" -
>  it is just a little confusing. Maybe W_Null or even Wchar_Null or
>  to make it more obvious that it is a programmer-defined variable?

I agree, but Tomasz didn't name this variable, it was already in the
code--that's how I missed it.  I don't think it's a problem in this
patch.
--Juan