Re: wininet: default to keep-alive when the server is HTTP/1.1, not when it isn't

[Huw Davies]

Vincent Povirk wrote:
> This is a fix to a problem I introduced in
> fd5b97bc4d12adc69085b739061c56e9107f8d1f. The expression that checked
> the HTTP version was true for HTTP/1.0 servers, and I treated it as if
> it were true for HTTP/1.1 servers. That means we defaulted to keep-alive
> for HTTP/1.0 servers only, the exact opposite of what we want.

This was a problem with the old code too, but what happens when we get
HTTP > 1.1 ?

Huw.

wininet: default to keep-alive when the server is HTTP/1.1, not when it isn't

[Hans Leidekker]

On Friday 15 August 2008 01:54:19 Huw Davies wrote:
> Vincent Povirk wrote:
> > This is a fix to a problem I introduced in
> > fd5b97bc4d12adc69085b739061c56e9107f8d1f. The expression that checked
> > the HTTP version was true for HTTP/1.0 servers, and I treated it as if
> > it were true for HTTP/1.1 servers. That means we defaulted to keep-alive
> > for HTTP/1.0 servers only, the exact opposite of what we want.
>
> This was a problem with the old code too, but what happens when we get
> HTTP > 1.1 ?

Yes, the keep-alive default will most likely be part of newer protocol
versions so we should change the code to match that, i.e. keep the
connection open unless the protocol version is 1.0 (perhaps even <= 1.0)
or if there's an explicit 'Connection: Close' header.

 -Hans