Valgrind warning in wined3d/swapchain.c in IWineD3DSwapChainImpl_Destroy

[Dan Kegel]

Hi Stefan,
you seem to have been in this code recently, could you have a look?
This is a somewhat flaky error that happens about 80% of the time
under heavy load on my quad core box.
(This is valgrind's xml output format, it's pretty fluffy, sorry.)

Thanks,
Dan


<error>
  <kind>UninitCondition</kind>
  <what>Conditional jump or move depends on uninitialised value(s)</what>
  <stack>
    <frame>
      <obj>dlls/wined3d/wined3d.dll.so</obj>
      <fn>IWineD3DSwapChainImpl_Destroy</fn>
      <dir>dlls/wined3d</dir>
      <file>swapchain.c</file>
      <line>75</line>
    </frame>
    <frame>
      <obj>dlls/d3d9/d3d9.dll.so</obj>
      <fn>IDirect3DSwapChain9Impl_Release</fn>
      <dir>dlls/d3d9</dir>
      <file>swapchain.c</file>
      <line>66</line>
    </frame>
    <frame>
      <obj>dlls/d3d9/d3d9.dll.so</obj>
      <fn>D3D9CB_DestroySwapChain</fn>
      <dir>dlls/d3d9</dir>
      <file>directx.c</file>
      <line>427</line>
    </frame>
    <frame>
      <obj>dlls/wined3d/wined3d.dll.so</obj>
      <fn>IWineD3DDeviceImpl_Uninit3D</fn>
      <dir>dlls/wined3d</dir>
      <file>device.c</file>
      <line>2426</line>
    </frame>
    <frame>
      <obj>dlls/d3d9/d3d9.dll.so</obj>
      <fn>IDirect3DDevice9Impl_Release</fn>
      <dir>dlls/d3d9</dir>
      <file>device.c</file>
      <line>98</line>
    </frame>
    <frame>
      <obj>dlls/d3d9/tests/d3d9_test.exe.so</obj>
      <fn>func_visual</fn>
      <dir>dlls/d3d9/tests</dir>
      <file>visual.c</file>
      <line>9960</line>
    </frame>
    <frame>
      <obj>dlls/d3d9/tests/d3d9_test.exe.so</obj>
      <fn>run_test</fn>
      <dir>dlls/d3d9/tests/../../../include/wine</dir>
      <file>test.h</file>
      <line>452</line>
    </frame>
    <frame>
      <obj>dlls/d3d9/tests/d3d9_test.exe.so</obj>
      <fn>main</fn>
      <dir>dlls/d3d9/tests/../../../include/wine</dir>
      <file>test.h</file>
      <line>502</line>
    </frame>
  </stack>
</error>

[Stefan Dösinger]

Hi,
I'm doing an mail purge and stumbled across this mail.

Can you try the attached patch?
> -----Original Message-----
> From: daniel.r.kegel(a)gmail.com [mailto:daniel.r.kegel(a)gmail.com] On
> Behalf Of Dan Kegel
> Sent: Saturday, November 15, 2008 5:30 AM
> To: Wine Devel
> Cc: Stefan Dösinger
> Subject: Valgrind warning in wined3d/swapchain.c in
> IWineD3DSwapChainImpl_Destroy
>
> Hi Stefan,
> you seem to have been in this code recently, could you have a look?
> This is a somewhat flaky error that happens about 80% of the time
> under heavy load on my quad core box.
> (This is valgrind's xml output format, it's pretty fluffy, sorry.)
>
> Thanks,
> Dan
>
> <error>
>   <kind>UninitCondition</kind>
>   <what>Conditional jump or move depends on uninitialised
> value(s)</what>
>   <stack>
>     <frame>
>       <obj>dlls/wined3d/wined3d.dll.so</obj>
>       <fn>IWineD3DSwapChainImpl_Destroy</fn>
>       <dir>dlls/wined3d</dir>
>       <file>swapchain.c</file>
>       <line>75</line>
>     </frame>
>     <frame>
>       <obj>dlls/d3d9/d3d9.dll.so</obj>
>       <fn>IDirect3DSwapChain9Impl_Release</fn>
>       <dir>dlls/d3d9</dir>
>       <file>swapchain.c</file>
>       <line>66</line>
>     </frame>
>     <frame>
>       <obj>dlls/d3d9/d3d9.dll.so</obj>
>       <fn>D3D9CB_DestroySwapChain</fn>
>       <dir>dlls/d3d9</dir>
>       <file>directx.c</file>
>       <line>427</line>
>     </frame>
>     <frame>
>       <obj>dlls/wined3d/wined3d.dll.so</obj>
>       <fn>IWineD3DDeviceImpl_Uninit3D</fn>
>       <dir>dlls/wined3d</dir>
>       <file>device.c</file>
>       <line>2426</line>
>     </frame>
>     <frame>
>       <obj>dlls/d3d9/d3d9.dll.so</obj>
>       <fn>IDirect3DDevice9Impl_Release</fn>
>       <dir>dlls/d3d9</dir>
>       <file>device.c</file>
>       <line>98</line>
>     </frame>
>     <frame>
>       <obj>dlls/d3d9/tests/d3d9_test.exe.so</obj>
>       <fn>func_visual</fn>
>       <dir>dlls/d3d9/tests</dir>
>       <file>visual.c</file>
>       <line>9960</line>
>     </frame>
>     <frame>
>       <obj>dlls/d3d9/tests/d3d9_test.exe.so</obj>
>       <fn>run_test</fn>
>       <dir>dlls/d3d9/tests/../../../include/wine</dir>
>       <file>test.h</file>
>       <line>452</line>
>     </frame>
>     <frame>
>       <obj>dlls/d3d9/tests/d3d9_test.exe.so</obj>
>       <fn>main</fn>
>       <dir>dlls/d3d9/tests/../../../include/wine</dir>
>       <file>test.h</file>
>       <line>502</line>
>     </frame>
>   </stack>
> </error>