Re: ieframe: Capitalize some menu items
Hi Jared, The patch still has NEW status, but I don't think I can sign it of myself. I'm not native speaker and I recall discussions about similar case on wine-devel in the past. I hope someone else can comment. Thanks, Jacek On 10/19/15 23:30, Jared Smudde wrote:
Signed-off-by: Jared Smudde <computerwhiz02(a)hotmail.com>
Some of the second words on menu items are not capitalized. This looks weird as some of the other menu items are all capitalized.
dlls/ieframe/ieframe.rc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/dlls/ieframe/ieframe.rc b/dlls/ieframe/ieframe.rc index aed8483..d4ccf3c 100644 --- a/dlls/ieframe/ieframe.rc +++ b/dlls/ieframe/ieframe.rc @@ -32,11 +32,11 @@ IDR_BROWSE_MAIN_MENU MENU } MENUITEM "&Open...", ID_BROWSE_OPEN MENUITEM "&Save", ID_BROWSE_SAVE - MENUITEM "Save &as...", ID_BROWSE_SAVE_AS + MENUITEM "Save &As...", ID_BROWSE_SAVE_AS MENUITEM SEPARATOR - MENUITEM "Print &format...", ID_BROWSE_PRINT_FORMAT + MENUITEM "Print &Format...", ID_BROWSE_PRINT_FORMAT MENUITEM "Pr&int...", ID_BROWSE_PRINT - MENUITEM "Print previe&w", ID_BROWSE_PRINT_PREVIEW + MENUITEM "Print Previe&w", ID_BROWSE_PRINT_PREVIEW MENUITEM SEPARATOR MENUITEM "&Properties", ID_BROWSE_PROPERTIES MENUITEM "&Close", ID_BROWSE_QUIT @@ -45,8 +45,8 @@ IDR_BROWSE_MAIN_MENU MENU { POPUP "&Toolbars" { - MENUITEM "&Standard bar", ID_BROWSE_BAR_STD - MENUITEM "&Address bar", ID_BROWSE_BAR_ADDR + MENUITEM "&Standard Bar", ID_BROWSE_BAR_STD + MENUITEM "&Address Bar", ID_BROWSE_BAR_ADDR } } POPUP "&Favorites"
On Thu, Oct 22, 2015 at 7:12 AM, Jacek Caban <jacek(a)codeweavers.com> wrote:
Hi Jared,
The patch still has NEW status, but I don't think I can sign it of myself. I'm not native speaker and I recall discussions about similar case on wine-devel in the past. I hope someone else can comment.
Thanks, Jacek
On 10/19/15 23:30, Jared Smudde wrote:
Signed-off-by: Jared Smudde <computerwhiz02(a)hotmail.com>
Some of the second words on menu items are not capitalized. This looks weird as some of the other menu items are all capitalized.
dlls/ieframe/ieframe.rc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/dlls/ieframe/ieframe.rc b/dlls/ieframe/ieframe.rc index aed8483..d4ccf3c 100644 --- a/dlls/ieframe/ieframe.rc +++ b/dlls/ieframe/ieframe.rc @@ -32,11 +32,11 @@ IDR_BROWSE_MAIN_MENU MENU } MENUITEM "&Open...", ID_BROWSE_OPEN MENUITEM "&Save", ID_BROWSE_SAVE - MENUITEM "Save &as...", ID_BROWSE_SAVE_AS + MENUITEM "Save &As...", ID_BROWSE_SAVE_AS MENUITEM SEPARATOR - MENUITEM "Print &format...", ID_BROWSE_PRINT_FORMAT + MENUITEM "Print &Format...", ID_BROWSE_PRINT_FORMAT MENUITEM "Pr&int...", ID_BROWSE_PRINT - MENUITEM "Print previe&w", ID_BROWSE_PRINT_PREVIEW + MENUITEM "Print Previe&w", ID_BROWSE_PRINT_PREVIEW MENUITEM SEPARATOR MENUITEM "&Properties", ID_BROWSE_PROPERTIES MENUITEM "&Close", ID_BROWSE_QUIT @@ -45,8 +45,8 @@ IDR_BROWSE_MAIN_MENU MENU { POPUP "&Toolbars" { - MENUITEM "&Standard bar", ID_BROWSE_BAR_STD - MENUITEM "&Address bar", ID_BROWSE_BAR_ADDR + MENUITEM "&Standard Bar", ID_BROWSE_BAR_STD + MENUITEM "&Address Bar", ID_BROWSE_BAR_ADDR } } POPUP "&Favorites"
Most English menu dialogs that I see on Debian and Windows are capitalized. E.g., Iceweasel / Firefox capitalize both the first and second words. Here's a screenshot of IE (7?) on Windows that I found online: http://www.sleewee.com/images/1-favorites-export.gif Signed-off-by: Austin English <austinenglish(a)gmail.com> -- -Austin
Austin English <austinenglish(a)gmail.com> writes:
Most English menu dialogs that I see on Debian and Windows are capitalized. E.g., Iceweasel / Firefox capitalize both the first and second words. Here's a screenshot of IE (7?) on Windows that I found online: http://www.sleewee.com/images/1-favorites-export.gif
I have no objection, but it should be done consistently. In particular strings like "Save as" are present in several modules, they should all be changed. -- Alexandre Julliard julliard(a)winehq.org
participants (3)
-
Alexandre Julliard -
Austin English -
Jacek Caban