Re: [PATCH 5/5] cmd: fix parameter parsing of quotes and special chars
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13898 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:301: Test failed: unexpected char 0x65 position 0 in line 7 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 8 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 9 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 10 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 11 (got '2 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 12 (got 'error 1', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 13 (got '0 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 14 (got '3 ', wanted '------ Testing invocation with CMD /C -------------') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 15 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 16 (got 'error 1', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 17 (got '4 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 18 (got 'error 1', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 19 (got '------ Testing invocation with CMD /C -------------', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 22 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 24 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 25 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 26 (got '1 ', wanted '4(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 27 (got '2 ', wanted '---------- Testing CMD /C quoting -----------------') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 28 (got '0 ', wanted '"hi"') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 29 (got '0 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 30 (got '3 ', wanted '"\"\\"\\\"\\\\"@space@"\"\\"\\\"\\\\"') batch.c:301: Test failed: unexpected char 0x34 position 0 in line 31 (got '4 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 32 (got '---------- Testing CMD /C quoting -----------------', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 33 (got '"hi"', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 34 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x22 position 0 in line 35 (got '"\"\\"\\\"\\\\" "\"\\"\\\"\\\\"', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 36 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 37 (got '0 ', wanted '3(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 38 (got '1 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 39 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 40 (got '0 ', wanted '2(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 42 (got '3 ', wanted '5(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 43 (got '2 ', wanted '---------- Testing CMD /C weirdness ---------------') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 44 (got '2 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x32 position 0 in line 45 (got '2 ', wanted '1(a)space@') batch.c:301: Test failed: unexpected char 0x35 position 0 in line 47 (got '5 ', wanted 'good') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 48 (got '---------- Testing CMD /C weirdness ---------------', wanted 'good') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 49 (got '0 ', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 50 (got '1 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 52 (got 'bad', wanted ')@space@') batch.c:301: Test failed: unexpected char 0x62 position 0 in line 53 (got 'bad', wanted '[@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 54 (got '--------- Testing special characters --------------', wanted ']@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 55 (got '0 ', wanted '{@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 56 (got '0 ', wanted '}@space@') batch.c:301: Test failed: unexpected char 0x29 position 0 in line 57 (got ') ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5b position 0 in line 58 (got '[ ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x5d position 0 in line 59 (got '] ', wanted '!@space@') batch.c:301: Test failed: unexpected char 0x7b position 0 in line 60 (got '{ ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x7d position 0 in line 61 (got '} ', wanted '+(a)space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 63 (got '0 ', wanted ''@space@') batch.c:301: Test failed: unexpected char 0x21 position 0 in line 64 (got '! ', wanted '~@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 65 (got '' ', wanted '--------- Testing parameter passing --------------') batch.c:301: Test failed: unexpected char 0x2b position 0 in line 66 (got '+ ', wanted '1:1,2:@space@') batch.c:301: Test failed: unexpected char 0x30 position 0 in line 67 (got '0 ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x27 position 0 in line 68 (got '' ', wanted '1:1(2),2:@space@') batch.c:301: Test failed: unexpected char 0x7e position 0 in line 69 (got '~ ', wanted '1:(1),2:@space@') batch.c:301: Test failed: unexpected char 0x2d position 0 in line 70 (got '--------- Testing parameter passing --------------', wanted '1:((1)),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 71 (got '1:1,2: ', wanted '1:(1)(2),2:@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 72 (got '1:(1),2: ', wanted '1:(1),2:(2)@space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 73 (got '1:1(2),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 74 (got '1:(1),2: ', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 75 (got 'error 1', wanted '1:1,2:2(a)space@') batch.c:301: Test failed: unexpected char 0x31 position 0 in line 76 (got '1:((1)),2: ', wanted '1:"p(a)space@"1,2:p"@space@"2(a)space@') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 77 (got 'error 1', wanted '1:p"1(a)space@p",2:2(a)space@') batch.c:315: Test failed: too long output, got additional 1:(1)(2),2: === W2KPROSP4 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === WXPPROSP3 (32 bit) === batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W2K3R2SESP2 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === WVISTAADM (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W2K8SE (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W7PRO (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W7PROX64 (32 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@ === W7PROX64 (64 bit) === batch.c:301: Test failed: unexpected char 0x33 position 0 in line 24 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x33 position 0 in line 36 (got '3 ', wanted '0(a)space@') batch.c:301: Test failed: unexpected char 0x69 position 0 in line 47 (got 'if errorlevel 1 (echo bad) else echo good', wanted 'good') batch.c:301: Test failed: unexpected char 0x63 position 0 in line 49 (got 'call :setError 0', wanted '--------- Testing special characters --------------') batch.c:301: Test failed: unexpected char 0x65 position 0 in line 50 (got 'exit /B %1', wanted '0(a)space@') batch.c:314: Test failed: unexpected end of output in line 50, missing 0(a)space@
participants (1)
-
Marvin