Re: comctl32: toolbar[1/4]: avoid using CopyImage as it doesn't work well when the DDBs are RGB565 (fixes bug #7905)

[Dmitry Timoshkov]

"Mikolaj Zalewski" <mikolaj(a)zalewski.pl> wrote:
> If the DDB format is RGB565, CopyImage uses an RGB555 intermediate DIB 
> that leads to data loses. This may change the COLOR_BTNFACE pixels 
> slightly and they won't be recognized as transparent anymore. As this 
> bug is also present under Windows, I haven't changed CopyImage but wrote 
> a new function that I hope works correctly.

Since it clearly sounds like a CopyImage bug it would be more appropriate
to fix CopyImage instead, Microsoft may do that at some point as well.

-- 
Dmitry.

comctl32: toolbar[1/4]: avoid using CopyImage as it doesn't work well when the DDBs are RGB565 (fixes bug #7905)

[Mikołaj Zalewski]

> Since it clearly sounds like a CopyImage bug it would be more appropriate
> to fix CopyImage instead, Microsoft may do that at some point as well.

I was a bit affraid that even Windows Vista has this bug so there 
might be apps depending on it. However it would be strange for some app 
to depend on it so if you think it's better to patch CopyImage I'll send 
a patch for it.

Mikolaj Zalewski