Re: [PATCH 4/4] mshtml: Added IHTMLElement:removeAttribute tests.

[Paul Vriens]

Hi Jacek,

On 03/24/2010 08:01 PM, Jacek Caban wrote:
> +function test_removeAttribute(e) {
> +    ok(e.removeAttribute('nonexisting') === false, "removeAttribute('nonexisting') didn't return false");
> +
> +    e.title = "title";
> +    ok(e.removeAttribute('title') === true, "removeAttribute('title') didn't return true");
> +    ok(e.title === "", "e.title = " + e.title);
> +    ok(("title" in e) === true, "title is not in e");
> (commenting that one)
> +
> +    e["myattr"] = "test";
> +    ok(e.removeAttribute('myattr') === true, "removeAttribute('myattr') didn't return true");
> +    ok(e["myattr"] === undefined, "e['myattr'] = " + e['myattr']);
> (and that one)
> +    ok(("myattr" in e) === false, "myattr is in e");
> (and that one makes the tests run again).
> +
> +}

These new tests introduce timeouts on IE5 (and lower?).

If I just open the jstest.html in a IE5 browser I get a warning for some 
of the lines:
> +    ok(("title" in e) === true, "title is not in e");
> +    ok(("myattr" in e) === false, "myattr is in e");

shows:

Line: 14
Char: 17 (18 for that second one of course)
Error: Expected ')'

-- 
Cheers,

Paul.

[PATCH 4/4] mshtml: Added IHTMLElement:removeAttribute tests.

[Jacek Caban]

Hi Paul,

On 03/26/10 10:40, Paul Vriens wrote:
> Hi Jacek,
>
> On 03/24/2010 08:01 PM, Jacek Caban wrote:
> > +function test_removeAttribute(e) {
> > +    ok(e.removeAttribute('nonexisting') === false,
> > "removeAttribute('nonexisting') didn't return false");
> > +
> > +    e.title = "title";
> > +    ok(e.removeAttribute('title') === true,
> > "removeAttribute('title') didn't return true");
> > +    ok(e.title === "", "e.title = " + e.title);
> > +    ok(("title" in e) === true, "title is not in e");
> > (commenting that one)
> > +
> > +    e["myattr"] = "test";
> > +    ok(e.removeAttribute('myattr') === true,
> > "removeAttribute('myattr') didn't return true");
> > +    ok(e["myattr"] === undefined, "e['myattr'] = " + e['myattr']);
> > (and that one)
> > +    ok(("myattr" in e) === false, "myattr is in e");
> > (and that one makes the tests run again).
> > +
> > +}
>
> These new tests introduce timeouts on IE5 (and lower?).

I think we should skip tests on these IEs. I've sent a patch.


Thanks,
    Jacek