Re: [PATCH] shlwapi: Handle PathCanonicalize with too long paths
29 Feb
2008
29 Feb
'08
5:09 a.m.
Marcus Meissner wrote:
lpszPath) { WCHAR szPath[MAX_PATH]; WCHAR szBuff[MAX_PATH]; - MultiByteToWideChar(CP_ACP,0,lpszPath,-1,szPath,MAX_PATH); + DWORD le = GetLastError(); + int ret = MultiByteToWideChar(CP_ACP,0,lpszPath,-1,szPath,MAX_PATH); + + if (!ret) { + FIXME("Failed to convert string to widechar (too long?), LE %d.\n", GetLastError()); + SetLastError (le); /* failure does not change Lasterror, see testcase. */ + return FALSE; + }
Hi Marcus, FIXME should be used for unimplemented functionality, not for highlighting application bugs that will happen on Windows too. WARN would be more appropriate here. -- Rob Shearman
6495
Age (days ago)
6495
Last active (days ago)
0 comments
1 participants
participants (1)
-
Robert Shearman