Re: comctl32/tests: Removed sign comparison warning in datetime tests.
On 10/05/2011 04:43 PM, Marko Nikolic wrote:
static void test_mccolor_types(HWND hWndDateTime, int mccolor_type, const char* mccolor_name) { - LRESULT r; - COLORREF theColor, prevColor; + //LRESULT r; + COLORREF theColor, prevColor, crColor;
Please avoid C++/C99-style comments in Wine code In this case you should remove the 'r' variable instead of commenting it out.
Joris Huizer wrote:
On 10/05/2011 04:43 PM, Marko Nikolic wrote:
static void test_mccolor_types(HWND hWndDateTime, int mccolor_type, const char* mccolor_name) { - LRESULT r; - COLORREF theColor, prevColor; + //LRESULT r; + COLORREF theColor, prevColor, crColor;
Please avoid C++/C99-style comments in Wine code In this case you should remove the 'r' variable instead of commenting it out.
Thanks, I missed it, it left from the testing. The whole line should be removed, I'll resend the patch. Marko
participants (2)
-
Joris Huizer -
Marko Nikolic