Re: dxdiagn: PhysicalMemory parameter is a string not long long
Vitaliy Margolen wrote:
--- dlls/dxdiagn/provider.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
Was anything wrong with this patch? I've used a simple utility DxDiagOutput.exe from DXSDK to find and test this. Vitaliy.
Vitaliy Margolen <wine-devel(a)kievinfo.com> writes:
Was anything wrong with this patch? I've used a simple utility DxDiagOutput.exe from DXSDK to find and test this.
The printf format is wrong. -- Alexandre Julliard julliard(a)winehq.org
Alexandre Julliard wrote:
Vitaliy Margolen <wine-devel(a)kievinfo.com> writes:
Was anything wrong with this patch? I've used a simple utility DxDiagOutput.exe from DXSDK to find and test this.
The printf format is wrong.
Well it really should be "%llu" but Wine doesn't support that. "%lu" is used btw at least in one place in the code: http://source.winehq.org/source/dlls/ntdll/actctx.c#L1746 What should it be then? The same as wine_dbgstr_longlong? Vitaliy.
Vitaliy Margolen <wine-devel(a)kievinfo.com> writes:
Well it really should be "%llu" but Wine doesn't support that. "%lu" is used btw at least in one place in the code: http://source.winehq.org/source/dlls/ntdll/actctx.c#L1746
It's the correct format for a ULONG_PTR.
What should it be then? The same as wine_dbgstr_longlong?
I doubt you want it to be in hex. You should use something like VariantChangeType. -- Alexandre Julliard julliard(a)winehq.org
Alexandre Julliard wrote:
Vitaliy Margolen <wine-devel(a)kievinfo.com> writes:
Well it really should be "%llu" but Wine doesn't support that. "%lu" is used btw at least in one place in the code: http://source.winehq.org/source/dlls/ntdll/actctx.c#L1746
It's the correct format for a ULONG_PTR.
Oh right missed the part that ULONG_PTR is 64-bit on win64 only.
What should it be then? The same as wine_dbgstr_longlong?
I doubt you want it to be in hex. You should use something like VariantChangeType.
Patch resent. Thanks for suggestion. Vitaliy.
participants (2)
-
Alexandre Julliard -
Vitaliy Margolen