Re: [PATCH 4/5] d3d9/tests: Extend focus loss tests.
I don't think the tests really support the implementation. For example, they don't test multiple swapchains at all, and they basically only test if WS_MINIMIZE is set or not as far as window styles are concerned. I'd expect at least some basic message and style tests along the lines of e.g. test_wndproc() and test_window_style().
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-09-23 13:52, schrieb Henri Verbeet:
I don't think the tests really support the implementation. For example, they don't test multiple swapchains at all, and they basically only test if WS_MINIMIZE is set or not as far as window styles are concerned. I'd expect at least some basic message and style tests along the lines of e.g. test_wndproc() and test_window_style(). Is the attached test what you had in mind? Mode switching is not included yet. Windows 7 and Windows Vista don't agree on the WM_WINDOWPOSCHANGING / WM_WINDOWPOSCHANGED parameters, so I'm not checking them. I can extend test_window_style as well to check for WS_VISIBLE, but I don't see a reason to do that given the messages being sent.
Wrt multiple swapchains, since we don't have any tests and support for multi-head or CreateAdditionalSwapchain in fullscreen mode that'd be a rather huge detour I'd prefer not to take. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJUIewwAAoJEN0/YqbEcdMwsZIP/2hTwfUuPLSKSoC8MQ4dtEju /awDAyXOtKLwYl1FzyTYr8yugqXpPiJk0PEuId2HppVHVnbhVhH16eOt+iCPDpOy J+9rzt08OaGEPp5tVpqExI7aqbMdb+sxNApqi1rRwzmLyl6fmSFJuNj8LRmu2hTR EuIrTSqOVZwXKVXOZJ7OdeYG6Vm7TefLT8AAIqeI6FmPcnwBg350nXa13V01OYlO tzsGzQSK3IPA/urL6BVZea6Yuh4++mIq5/CFsTwfxXqjbnFKy+nUvtt4F7icJpe2 YgHb02C6eVm3vvwyatO/gfxqAjMhF3AoUo2bVnbLA55bM45H7EjDlBm6xAZuIevE 4qCl/Rdk9dMNTjI8e/s5PjGkJpJgn+LvWFFJBG6AmE5zJqGKswRhMjwLPP8WdVEl mUNtG3QutggqWfK3h2IXtA27GhUR8z8yi8oxLt4l/Oh2X18iTD1BjXNkFPJrKnIL Tr7eafhMW5R0GwNDfA9ImKMS4IIkWylhrIcIKhuDKpGUz3j5QqQ+TkHOwPob6xez kx+5B/9fRqVcepbEpfw7UHxcbW4P3l4Q/kkP02cRSETAKetO8vn17jA8GMzGfdGV mURE0QLciZ/d4/4kkjwv/fvLjilaW+qWi5FVgSWhOFg3ay2jrLadmCFQfnOmgmfG 0QEZ+3dkS2TAqb+MyCN+ =jmOV -----END PGP SIGNATURE-----
On 23 September 2014 23:54, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
Am 2014-09-23 13:52, schrieb Henri Verbeet:
I don't think the tests really support the implementation. For example, they don't test multiple swapchains at all, and they basically only test if WS_MINIMIZE is set or not as far as window styles are concerned. I'd expect at least some basic message and style tests along the lines of e.g. test_wndproc() and test_window_style(). Is the attached test what you had in mind? Mode switching is not Something along those lines, yeah. You'll probably want to use a wparam mask instead of multiple expected values, and I'd prefer WA_INACTIVE over 0 in the appropriate places.
I can extend test_window_style as well to check for WS_VISIBLE, but I don't see a reason to do that given the messages being sent.
You probably mostly care about WS_MINIMIZE, but it's also to verify that there are no other style changes. I imagine this would also be useful if we ever get around to finishing e.g. a WGL extension for switching to/from fullscreen.
Wrt multiple swapchains, since we don't have any tests and support for multi-head or CreateAdditionalSwapchain in fullscreen mode that'd be a rather huge detour I'd prefer not to take.
I suspect that adding tests for CreateAdditionalSwapChain() at least would only be a modest amount of work, but without tests, I'd expect that we should only minimize the fullscreen swapchain. Or, put a different way, only the window that we received the message for.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2014-09-24 13:21, schrieb Henri Verbeet:
I suspect that adding tests for CreateAdditionalSwapChain() at least would only be a modest amount of work, but without tests, I'd expect that we should only minimize the fullscreen swapchain. Or, put a different way, only the window that we received the message for. The window we receive the message for is the focus window, and windows doesn't touch it at all (unless of course device window == focus window). -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJUIveCAAoJEN0/YqbEcdMwcxsP/0TFjZ9b0HWrMiLLm0Y6OTsk UML3T9heaoc2TlBWcHwOTfe9+D5Z7fqligSACJvkWuR6s+Rq33kYwGtVbM5FdQIy 2bT9c40LhZs8eAUECBKZP71+ACSgpnBR6TQBkC71nmmYX5pS44EDMxno8NKggRmn C9pJ0i0miEa++cOeGVGsRJxm7/Wg5A8x0k78t6NTWm84a8Mx67HILK+kpLUIujdT /f2StxINaE+MxApfZvSclE0nNc6Yb+IBdYLQvNGkXU7bL3JH0cvmAF4qNlqab+Ew 8qMcIRouf8fTpLnrNIVL+Hq/kxbOeRk1V6PlC0Lt1nhsNwO/jPsYfSbBEHkfxMEr BzQ6IdctSLI9W1V4YCCZAUC80TgsHy1Zcpb+r9h+2stNr6DRSvMxIgLY4vL6TLBr UkcZ7Xz84tVaO3s2rWJs9z2Ioe1ZdtxLvJJjn3IEHufcRvKsOQXGhEwhXvVsBoA8 Ix/Q+Q9839D+s2gqmUpHHkO/wq1LcMmQsBJkN/Y3PSQhmo+JlEC0qyp+LpWr6/XT mBrGfXMbFU8Opzm8//TeFeHXTaPcdd/0YaTWnsb4MccBoDvMAe1aVciXEDZiFrYs +nOTdWx4k0j95yvHFoCQ2RqSR2DQKKv5F9NkhBzi7pMktbHBNGdcupwE620r/VmZ AdxUvrAPrCObCmpe4DKA =vbb2 -----END PGP SIGNATURE-----
participants (2)
-
Henri Verbeet -
Stefan Dösinger