Re: 1/4 wined3d: Move argb_to_fmt to utils.c as a helper function to be used in more places.

[Stefan Dösinger]

Am Donnerstag 25 März 2010 23:02:33 schrieb Roderick Colenbrander:
>

+DWORD color_convert_argb_to_fmt(DWORD color, WINED3DFORMAT destfmt)
This only works with formats that are encoded in integers with 32 bit or less. 
Do we care about this limitation?

1/4 wined3d: Move argb_to_fmt to utils.c as a helper function to be used in more places.

[Roderick Colenbrander]

On Thu, Mar 25, 2010 at 11:58 PM, Stefan Dösinger
<stefan(a)codeweavers.com> wrote:
> Am Donnerstag 25 März 2010 23:02:33 schrieb Roderick Colenbrander:
> >
>
> +DWORD color_convert_argb_to_fmt(DWORD color, WINED3DFORMAT destfmt)
> This only works with formats that are encoded in integers with 32 bit or less.
> Do we care about this limitation?

At the moment this code is called to fall back to  'legacy' color fill
/ clear related calls and that's also what I intend to use it for in
blit_shader. I'm not sure if we should handle 128-bit float support in
the fallbacks. I agree that later on perhaps we could make this
function more generic. The move to utils.c is a first step. The same
can be said about the blit_shader fill_color which can later on also
be extended if we want to use it from device.c but I don't think it is
wise to change it all in the first iteration.

Roderick

1/4 wined3d: Move argb_to_fmt to utils.c as a helper function to be used in more places.

[Henri Verbeet]

On 25 March 2010 23:58, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> Am Donnerstag 25 März 2010 23:02:33 schrieb Roderick Colenbrander:
> >
>
> +DWORD color_convert_argb_to_fmt(DWORD color, WINED3DFORMAT destfmt)
> This only works with formats that are encoded in integers with 32 bit or less.
> Do we care about this limitation?

We do, but as far as I'm concerned not for this patch.