Try#4 for IDirectDrawSurface_GetSurfaceDesc error checking in ddraw test

[chris ahrendt]

Michael / All,

Been busy for awhile so have not had the time to work on this patch but 
here is the 4th try and hopefully final version of the ddraw patch.

I took Michaels suggestions and encorporated them into the patch as well.

Please let me know if this patch is now ready to submit =)


chris

Try#4 for IDirectDrawSurface_GetSurfaceDesc error checking in ddraw test

[Stefan Dösinger]

About the content:
With which error code does the surface creation fail? Usually having an
ok(hr == DD_OK) and then catching a failure needs a second look. It isn't
necessarily wrong - there can be a driver bug. However, it is possible that
we're not checking caps well enough and the test doesn't realize that it is
trying to test something unsupported

Style:

The whitespaces on the closing brackets are different from what I remember
from the rest of the file:

if(blabla) {
    foofoo
  }

vs

if(blabla) {
    foofoo
}

You can also avoid the 4 different goto labels if you make sure that the
surface pointers are initialized to NULL, then jump to one err label and
check for NULL before releasing any surface.
> -----Original Message-----
> From: wine-devel-bounces(a)winehq.org [mailto:wine-devel-
> bounces(a)winehq.org] On Behalf Of chris ahrendt
> Sent: Friday, November 14, 2008 2:58 PM
> To: wine(a)mkarcher.dialup.fu-berlin.de
> Cc: wine-devel(a)winehq.org
> Subject: Try#4 for IDirectDrawSurface_GetSurfaceDesc error checking in
> ddraw test
>
> Michael / All,
>
> Been busy for awhile so have not had the time to work on this patch but
> here is the 4th try and hopefully final version of the ddraw patch.
>
> I took Michaels suggestions and encorporated them into the patch as
> well.
>
> Please let me know if this patch is now ready to submit =)
>
> chris