Re: [PATCH 9/9] ws2_32/tests: add some socket event tests

[Paul Vriens]

On 03/24/2010 03:03 AM, Mike Kaplinskiy wrote:
> ---
>   dlls/ws2_32/tests/Makefile.in |    2 +-
>   dlls/ws2_32/tests/sock.c      |  735 +++++++++++++++++++++++++++++++++++++----
>   2 files changed, 672 insertions(+), 65 deletions(-)

Hi Mike,

I took the liberty of running your new tests on winetestbot. It shows 
failures on Win98:

https://winetestbot.geldorp.nl/JobDetails.pl?Key=1164

(Win95 fails of course due to missing ws2_32.dll so these tests won't 
even run via winetest.exe).

-- 
Cheers,

Paul.

[PATCH 9/9] ws2_32/tests: add some socket event tests

[Mike Kaplinskiy]

On Wed, Mar 24, 2010 at 12:17 PM, Paul Vriens
<paul.vriens.wine(a)gmail.com> wrote:
> On 03/24/2010 03:03 AM, Mike Kaplinskiy wrote:
> > ---
> >  dlls/ws2_32/tests/Makefile.in |    2 +-
> >  dlls/ws2_32/tests/sock.c      |  735
> > +++++++++++++++++++++++++++++++++++++----
> >  2 files changed, 672 insertions(+), 65 deletions(-)
>
> Hi Mike,
>
> I took the liberty of running your new tests on winetestbot. It shows
> failures on Win98:
>
> https://winetestbot.geldorp.nl/JobDetails.pl?Key=1164
>
> (Win95 fails of course due to missing ws2_32.dll so these tests won't even
> run via winetest.exe).
>
> --
> Cheers,
>
> Paul.

Hey Paul,

I'm starting to not like win98. Sorry again. I recently discovered
that winetestbot doesn't run on win98 by default - will keep that in
mind in the future. Is there any reason for that?

I've got a fix, although I doubt the series will be committed at all
today; I'll just merge it next time.

Thanks again,
Mike.

[PATCH 9/9] ws2_32/tests: add some socket event tests

[Paul Vriens]

On 03/24/2010 08:36 PM, Mike Kaplinskiy wrote:
> On Wed, Mar 24, 2010 at 12:17 PM, Paul Vriens
> <paul.vriens.wine(a)gmail.com>  wrote:
> > On 03/24/2010 03:03 AM, Mike Kaplinskiy wrote:
> > > ---
> > >   dlls/ws2_32/tests/Makefile.in |    2 +-
> > >   dlls/ws2_32/tests/sock.c      |  735
> > > +++++++++++++++++++++++++++++++++++++----
> > >   2 files changed, 672 insertions(+), 65 deletions(-)
> >
> > Hi Mike,
> >
> > I took the liberty of running your new tests on winetestbot. It shows
> > failures on Win98:
> >
> > https://winetestbot.geldorp.nl/JobDetails.pl?Key=1164
> >
> > (Win95 fails of course due to missing ws2_32.dll so these tests won't even
> > run via winetest.exe).
> >
> > --
> > Cheers,
> >
> > Paul.
>
> Hey Paul,
>
> I'm starting to not like win98. Sorry again. I recently discovered
> that winetestbot doesn't run on win98 by default - will keep that in
> mind in the future. Is there any reason for that?

The main reason is that the Win9x boxes run on a different server under 
the supervision of VMware server. All other boxes run on ESX.
> I've got a fix, although I doubt the series will be committed at all
> today; I'll just merge it next time.

Thanks.

-- 
Cheers,

Paul.