[PATCH v2 6/7] adsldp: empty ExecuteSearch() is S_OK, GetFirstRow()/GetNextRow() then return S_ADS_NOMORE_ROWS
Some search errors are returned from ExecuteSearch(), but empty search results definitely result in S_OK from ExecuteSearch() and S_ADS_NOMORE_ROWS from subsequent GetFirstRow()/GetNextRow(). Try 2 adds a test, and doesn't report all errors through GetFirstRow()/GetNextRow(). Signed-off-by: Damjan Jovanovic <damjan.jov(a)gmail.com> --- dlls/adsldp/adsldp.c | 18 ++++++++++++++---- dlls/adsldp/tests/ldap.c | 7 +++++++ 2 files changed, 21 insertions(+), 4 deletions(-)
Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=85536 Your paranoid android. === debiant2 (32 bit report) === wldap32: Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x7e9b697e). === debiant2 (32 bit Chinese:China report) === wldap32: Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x7e92c97e). === debiant2 (32 bit WoW report) === wldap32: Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x7e9b697e). === debiant2 (64 bit WoW report) === wldap32: Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x7e9b697e).
participants (2)
-
Damjan Jovanovic -
Marvin