New subject: [PATCH v3 2/2] quartz: Remove source filter added by IGraphBuilder::RenderFile on failure

28 Jun 2021

Signed-off-by: Tim Clem <tclem(a)codeweavers.com>
---
 dlls/quartz/tests/filtergraph.c | 40 +++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/dlls/quartz/tests/filtergraph.c b/dlls/quartz/tests/filtergraph.c
index fdcfcead0be..f0d7d7c275e 100644
--- a/dlls/quartz/tests/filtergraph.c
+++ b/dlls/quartz/tests/filtergraph.c
@@ -4186,6 +4186,45 @@ static void test_ec_complete(void)
     ok(filter3.ref == 1, "Got outstanding refcount %d.\n", filter3.ref);
 }
 
+static void test_renderfile_failure(void)
+{
+    static const char bogus_data[20] = {0xde, 0xad, 0xbe, 0xef};
+
+    struct testfilter testfilter;
+    IFilterGraph2 *graph;
+    IEnumFilters *filterenum;
+    IBaseFilter *filter;
+    HRESULT hr;
+    const WCHAR *filename;
+
+    /* Windows removes the source filter from the graph if a RenderFile
+     * call fails. It leaves the rest of the graph intact. */
+
+    graph = create_graph();
+    testfilter_init(&testfilter, NULL, 0);
+    hr = IFilterGraph2_AddFilter(graph, &testfilter.IBaseFilter_iface, L"dummy");
+    ok(hr == S_OK, "Got hr %#x.\n", hr);
+
+    filename = create_file(L"test.nonsense", bogus_data, sizeof(bogus_data));
+    hr = IFilterGraph2_RenderFile(graph, filename, NULL);
+    todo_wine ok(hr == VFW_E_UNSUPPORTED_STREAM, "Got hr %#x.\n", hr);
+
+    hr = IFilterGraph2_EnumFilters(graph, &filterenum);
+    ok(hr == S_OK, "Got hr %#x.\n", hr);
+
+    hr = IEnumFilters_Next(filterenum, 1, &filter, NULL);
+    ok(hr == S_OK, "Got hr %#x.\n", hr);
+    todo_wine ok(filter == &testfilter.IBaseFilter_iface, "Got unexpected filter %p.\n", filter);
+
+    hr = IEnumFilters_Next(filterenum, 1, &filter, NULL);
+    todo_wine ok(hr == S_FALSE, "Got hr %#x.\n", hr);
+
+    IEnumFilters_Release(filterenum);
+
+    IFilterGraph2_Release(graph);
+    todo_wine ok(DeleteFileW(filename), "Failed to delete temporary file.\n");
+}
+
 /* Remove and re-add the filter, to flush the graph's internal
  * IMediaSeeking cache. Don't expose IMediaSeeking when adding, to show
  * that it's only queried when needed. */
@@ -5645,6 +5684,7 @@ START_TEST(filtergraph)
     test_sync_source();
     test_filter_state();
     test_ec_complete();
+    test_renderfile_failure();
     test_graph_seeking();
     test_default_sync_source();
     test_add_source_filter();
-- 
2.32.0

    

[PATCH v3 1/2] quartz/tests: Test IGraphBuilder::RenderFile cleanup on failure

Tim Clem

Tim Clem

Marvin

Marvin

tags

participants (2)