re: xmllite: Store DTD processing mode in reader

[Dan Kegel]

Alexandre Julliard wrote:
> Explicit ok() calls are better than hiding them inside a macro.

Uh-oh.  Want me to get rid of this macro

+#define CHECK_RET_ERRNO(ret, ex) \
+    do { \
+        ok(ret == ex, "ret is %d, expected %d\n", ret, ex); \
+        ok(errno == ex, "errno is %d, expected %d\n", errno, ex); \
+    } while (0)

in http://source.winehq.org/patches/data/89349 ?

xmllite: Store DTD processing mode in reader

[Alexandre Julliard]

Dan Kegel <dank(a)kegel.com> writes:
> Alexandre Julliard wrote:
> > Explicit ok() calls are better than hiding them inside a macro.
>
> Uh-oh.  Want me to get rid of this macro
>
> +#define CHECK_RET_ERRNO(ret, ex) \
> +    do { \
> +        ok(ret == ex, "ret is %d, expected %d\n", ret, ex); \
> +        ok(errno == ex, "errno is %d, expected %d\n", errno, ex); \
> +    } while (0)
>
> in http://source.winehq.org/patches/data/89349 ?

Obviously, yes.

-- 
Alexandre Julliard
julliard(a)winehq.org