Re: dlls/ole32: check some dead store results (llvm/clang)
20 Nov
2008
20 Nov
'08
6:45 p.m.
Am Donnerstag, den 20.11.2008, 18:36 +0000 schrieb ricardo filipe: | - if ((err=RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey))) { | + if (RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey) == ERROR_SUCCESS) { No. This inverts the logic of the tests. if(x) means if(x != 0). And ERROR_SUCCESS is just zero. To prevent just this possible mistake, a patch making the condition obvious was requested. Regards, Michael Karcher
6234
Age (days ago)
6234
Last active (days ago)
0 comments
1 participants
participants (1)
-
Michael Karcher