Re: [2/3] winex11.drv: Don't modify current state if glXMakeCurrent fails.
I'm not sure if the only value error wglMakeCurrent should return is INVALID_HANDLE. What if glXMakeCurrent fails because of an invalid context? The return value may be similar, but don't remember for sure. Roderick On Tue, Mar 29, 2011 at 7:42 AM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote:
2011/3/29 Roderick Colenbrander <thunderbird2k(a)gmail.com>:
I'm not sure if the only value error wglMakeCurrent should return is INVALID_HANDLE. What if glXMakeCurrent fails because of an invalid context? The return value may be similar, but don't remember for sure.
Roderick
Practically speaking it seems to be very dependent on the specific GL driver used. For example, current Nvidia Windows drivers just accept a wglMakeCurrent call with a destroyed context (no errors at all), while I think AMD drivers crash in the same case. I'm not sure I specifically tested that on glX too, but in general, failing on a destroyed drawable was the only consistent "edge case" behavior I found.
On Tue, Mar 29, 2011 at 7:42 AM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote:
The first part of the patch was fine, the only concern is the error code. Since there is no WGL standard, the error codes thrown by different drivers can be inconsistent :( I'm not sure if it is better to set an error code at all or not. I'm not sure what I would prefer... Roderick On Tue, Mar 29, 2011 at 5:55 PM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote:
2011/3/29 Roderick Colenbrander <thunderbird2k(a)gmail.com>:
I'm not sure if the only value error wglMakeCurrent should return is INVALID_HANDLE. What if glXMakeCurrent fails because of an invalid context? The return value may be similar, but don't remember for sure.
Roderick
Practically speaking it seems to be very dependent on the specific GL driver used. For example, current Nvidia Windows drivers just accept a wglMakeCurrent call with a destroyed context (no errors at all), while I think AMD drivers crash in the same case. I'm not sure I specifically tested that on glX too, but in general, failing on a destroyed drawable was the only consistent "edge case" behavior I found.
On Tue, Mar 29, 2011 at 7:42 AM, Matteo Bruni <matteo.mystral(a)gmail.com> wrote:
participants (2)
-
Matteo Bruni -
Roderick Colenbrander