[PATCH 1/5] ucrtbase/tests: Use more functions directly.

[Jacek Caban]

Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
---
  dlls/ucrtbase/tests/misc.c | 122 +++++++++++++------------------------
  1 file changed, 44 insertions(+), 78 deletions(-)

[Marvin]

Hi,

While running your changed tests, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?

Full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=67075

Your paranoid android.


=== w1064v1809_he (32 bit report) ===

ucrtbase:
misc.c:1396: Test failed: clock() = 571, expected range [375, 375]

[Alexandre Julliard]

Jacek Caban <jacek(a)codeweavers.com> writes:
> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
> ---
>  dlls/ucrtbase/tests/misc.c | 122 +++++++++++++------------------------
>  1 file changed, 44 insertions(+), 78 deletions(-)

This causes warnings:

i686-w64-mingw32-gcc -c -o misc.cross.o misc.c -I. -I../../../include -I../../../include/msvcrt -D__WINESRC__ -D_UCRT \
  -DWINE_CROSS_PE -Wall -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body \
  -Wignored-qualifiers -Wno-packed-not-aligned -Wshift-overflow=2 -Wstrict-prototypes -Wtype-limits \
  -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith -Wlogical-op \
  -fno-omit-frame-pointer -gdwarf-2 -gstrict-dwarf -Werror -g -O2 -fno-diagnostics-show-caret
misc.c: In function ‘test_strftime’:
misc.c:1135:42: error: unknown conversion type character ‘g’ in format [-Werror=format=]
misc.c:1135:45: error: unknown conversion type character ‘V’ in format [-Werror=format=]
misc.c:1148:40: error: unknown conversion type character ‘r’ in format [-Werror=format=]
cc1: all warnings being treated as errors
make[1]: *** [Makefile:205: misc.cross.o] Error 1

-- 
Alexandre Julliard
julliard(a)winehq.org

[Jacek Caban]

On 13.03.2020 20:10, Alexandre Julliard wrote:
> Jacek Caban <jacek(a)codeweavers.com> writes:
> > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com>
> > ---
> >   dlls/ucrtbase/tests/misc.c | 122 +++++++++++++------------------------
> >   1 file changed, 44 insertions(+), 78 deletions(-)
> > This causes warnings:
>
> i686-w64-mingw32-gcc -c -o misc.cross.o misc.c -I. -I../../../include -I../../../include/msvcrt -D__WINESRC__ -D_UCRT \
>    -DWINE_CROSS_PE -Wall -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body \
>    -Wignored-qualifiers -Wno-packed-not-aligned -Wshift-overflow=2 -Wstrict-prototypes -Wtype-limits \
>    -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith -Wlogical-op \
>    -fno-omit-frame-pointer -gdwarf-2 -gstrict-dwarf -Werror -g -O2 -fno-diagnostics-show-caret
> misc.c: In function ‘test_strftime’:
> misc.c:1135:42: error: unknown conversion type character ‘g’ in format [-Werror=format=]
> misc.c:1135:45: error: unknown conversion type character ‘V’ in format [-Werror=format=]
> misc.c:1148:40: error: unknown conversion type character ‘r’ in format [-Werror=format=]
> cc1: all warnings being treated as errors
> make[1]: *** [Makefile:205: misc.cross.o] Error 1

Sorry for not noticing, clang handles that correctly. Those tests will 
need -fno-builtin (which I expect that may be a good idea for crt tests 
anyway). I will send a new version later.


Thanks,

Jacek