Re: dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

[Austin English]

On Tue, Oct 14, 2008 at 5:11 PM, Joris Huizer <joris_huizer(a)yahoo.com> wrote:
> When pszExtra is unequal to zero, set pszExtraFromReg to zero as it'll get free'd later on;
>
> (Another way would be to set the variable to NULL explicitly if it's desirable to make this case very explicit)

"From: Joris Huizer <jorishuizer(a)debian.(none)>"

Minor, but please fix your e-mail in the patch:

Also, please set patch extensions to .txt, it makes it easier to read
in browser.

-- 
-Austin

dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

[Joris Huizer]

--- On Thu, 10/16/08, Austin English <austinenglish(a)gmail.com> wrote:
> "From: Joris Huizer
> <jorishuizer(a)debian.(none)>"
>
> Minor, but please fix your e-mail in the patch:
>
> Also, please set patch extensions to .txt, it makes it
> easier to read
> in browser.

Alright, I did a resent with the corrected email address and .txt extension.
Though I didn't manage to get git to fill in the correct address (it currently just tries to use the debian user name, which it can't turn into a real email address). How could I get git to fill in the address automatically? I couldn't find this at the GitWine page. (git format-patch seems to ignore the user/email pair as suggested for sending patches with git-imap-send)

Thanks,

Joris

dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

[Austin English]

On Fri, Oct 17, 2008 at 5:57 AM, Joris Huizer <joris_huizer(a)yahoo.com> wrote:
> --- On Thu, 10/16/08, Austin English <austinenglish(a)gmail.com> wrote:
> > "From: Joris Huizer
> > <jorishuizer(a)debian.(none)>"
> >
> > Minor, but please fix your e-mail in the patch:
> >
> > Also, please set patch extensions to .txt, it makes it
> > easier to read
> > in browser.
>
> Alright, I did a resent with the corrected email address and .txt extension.
> Though I didn't manage to get git to fill in the correct address (it currently just tries to use the debian user name, which it can't turn into a real email address). How could I get git to fill in the address automatically? I couldn't find this at the GitWine page. (git format-patch seems to ignore the user/email pair as suggested for sending patches with git-imap-send)
>
> Thanks,
>
> Joris

git repo-config user.name "Your Name"
git repo-config user.email "me(a)example.com"


-- 
-Austin

dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

[Joris Huizer]

--- On Fri, 10/17/08, Austin English <austinenglish(a)gmail.com> wrote:
> git repo-config user.name "Your Name"
> git repo-config user.email "me(a)example.com"

Uhm no that doesn't work. I had already tried that (or actually, the equivalent of adding these to .git/config) but it didn't make any difference

Is there something missing when using `git format-patch --keep-subject -o out origin` to generate the patch? This command is suggested on the gitWine page.

Thanks,

Joris

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com

dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

[Rob Shearman]

2008/10/18 Joris Huizer <joris_huizer(a)yahoo.com>:
> --- On Fri, 10/17/08, Austin English <austinenglish(a)gmail.com> wrote:
> > git repo-config user.name "Your Name"
> > git repo-config user.email "me(a)example.com"
>
> Uhm no that doesn't work. I had already tried that (or actually, the equivalent of adding these to .git/config) but it didn't make any difference
>
> Is there something missing when using `git format-patch --keep-subject -o out origin` to generate the patch? This command is suggested on the gitWine page.

The information is added at commit time so it won't make any
difference if you just run "git format-patch" after configuring the
above settings, it matters what the settings were when you committed.

If you haven't committed anything since you can do:
git reset HEAD^
git commit

And then enter your commit message again and this will create a new
commit with the correct author information.

-- 
Rob Shearman

dlls/shlwapi/assoc.c:fix ASSOC_GetExecutable not to use uninitialised variable

[Joris Huizer]

--- On Sun, 10/19/08, Rob Shearman <robertshearman(a)gmail.com> wrote:
> The information is added at commit time so it won't
> make any
> difference if you just run "git format-patch"
> after configuring the
> above settings, it matters what the settings were when you
> committed.
>
> If you haven't committed anything since you can do:
> git reset HEAD^
> git commit
>
> And then enter your commit message again and this will
> create a new
> commit with the correct author information.

Thanks, it worked indeed, so next time the patch will have correct contact information

Joris

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com