Re: comdlg32: Resize Find dialog to fit translations

[Dmitry Timoshkov]

Aurimas Fišeras <aurimas(a)gmail.com> wrote:
> Controls resized to fit translations for more languages. Tested with
> resource editor.

Did you see a comment in that file just before dialog templates?

-- 
Dmitry.

comdlg32: Resize Find dialog to fit translations

[Aurimas Fišeras]

2012.12.02 07:46, Dmitry Timoshkov rašė:
> Aurimas Fišeras <aurimas(a)gmail.com> wrote:
> > Controls resized to fit translations for more languages. Tested with
> > resource editor.
>
> Did you see a comment in that file just before dialog templates?

Hello,
I obviously didn't notice that comment.

Why do we have such a limitation?

I checked the sizes of this dialog before conversion to po files [1] and
they were quite different between various languages.

[1]
http://source.winehq.org/git/wine.git/commit/1fa1ab54376bace57f78d27ac13b722...

comdlg32: Resize Find dialog to fit translations

[Dmitry Timoshkov]

Aurimas Fišeras <aurimas(a)gmail.com> wrote:
> > > Controls resized to fit translations for more languages. Tested with
> > > resource editor.
> >
> > Did you see a comment in that file just before dialog templates?
>
> Hello,
> I obviously didn't notice that comment.
>
> Why do we have such a limitation?

Applications that use custom dialog templates and subclass the original
ones (or rather the algorithm in comctl32 that resizes custom dialogs)
depend on this .
> I checked the sizes of this dialog before conversion to po files [1] and
> they were quite different between various languages.

If the dialog sizes differ from Windows templates - that's a bug and
should be fixed.

-- 
Dmitry.

comdlg32: Resize Find dialog to fit translations

[Aurimas Fišeras]

2012.12.02 20:32, Dmitry Timoshkov rašė:
> Aurimas Fišeras <aurimas(a)gmail.com> wrote:
> > > > Controls resized to fit translations for more languages. Tested with
> > > > resource editor.
> > >
> > > Did you see a comment in that file just before dialog templates?
> >
> > Hello,
> > I obviously didn't notice that comment.
> >
> > Why do we have such a limitation?
>
> Applications that use custom dialog templates and subclass the original
> ones (or rather the algorithm in comctl32 that resizes custom dialogs)
> depend on this .
> > I checked the sizes of this dialog before conversion to po files [1] and
> > they were quite different between various languages.
>
> If the dialog sizes differ from Windows templates - that's a bug and
> should be fixed.

I see.

What about something like the attached patch? I resized both check boxes
and the direction group, positioned radio buttons in the direction group
one above the other.

I checked this dialog on Windows XP Lithuanian UI, and it had similar
differences from the English one.

comdlg32: Resize Find dialog to fit translations

[Dmitry Timoshkov]

Aurimas Fišeras <aurimas(a)gmail.com> wrote:
> What about something like the attached patch? I resized both check boxes
> and the direction group, positioned radio buttons in the direction group
> one above the other.
>
> I checked this dialog on Windows XP Lithuanian UI, and it had similar
> differences from the English one.

That's an acceptable approach.

-- 
Dmitry.