Re: [PATCH] mscoree: Print the correct values in a TRACE.
Le 23 mars 2012 21:41, Lauri Kenttä <lauri.kentta(a)gmail.com> a écrit :
--- dlls/mscoree/mscoree_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/mscoree/mscoree_main.c b/dlls/mscoree/mscoree_main.c index 1aa120f..0ebc813 100644 --- a/dlls/mscoree/mscoree_main.c +++ b/dlls/mscoree/mscoree_main.c @@ -359,7 +359,7 @@ HRESULT WINAPI GetRequestedRuntimeInfo(LPCWSTR pExe, LPCWSTR pwszVersion, LPCWST
HRESULT WINAPI GetRequestedRuntimeVersion(LPWSTR pExe, LPWSTR pVersion, DWORD cchBuffer, DWORD *dwlength) { - TRACE("(%s, %p, %d, %p)\n", debugstr_w(pExe), debugstr_w(pExe), cchBuffer, dwlength); + TRACE("(%s, %p, %d, %p)\n", debugstr_w(pExe), pVersion, cchBuffer, dwlength);
if(!dwlength) return E_POINTER; -- 1.7.9.4
Hi Lauri, Should be %s debugstr_w(pVersion) IMHO. -- Nicolas Le Cam
On Mar 23, 2012, at 3:09 PM, Nicolas Le Cam wrote:
Le 23 mars 2012 21:41, Lauri Kenttä <lauri.kentta(a)gmail.com> a écrit :
--- dlls/mscoree/mscoree_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/mscoree/mscoree_main.c b/dlls/mscoree/mscoree_main.c index 1aa120f..0ebc813 100644 --- a/dlls/mscoree/mscoree_main.c +++ b/dlls/mscoree/mscoree_main.c @@ -359,7 +359,7 @@ HRESULT WINAPI GetRequestedRuntimeInfo(LPCWSTR pExe, LPCWSTR pwszVersion, LPCWST
HRESULT WINAPI GetRequestedRuntimeVersion(LPWSTR pExe, LPWSTR pVersion, DWORD cchBuffer, DWORD *dwlength) { - TRACE("(%s, %p, %d, %p)\n", debugstr_w(pExe), debugstr_w(pExe), cchBuffer, dwlength); + TRACE("(%s, %p, %d, %p)\n", debugstr_w(pExe), pVersion, cchBuffer, dwlength);
if(!dwlength) return E_POINTER; -- 1.7.9.4
Hi Lauri,
Should be %s debugstr_w(pVersion) IMHO. No, that's an out parameter. (It's hard to tell, because the in parameter pExe is of type LPWSTR instead of LPCWSTR.)
Chip
Le 23 mars 2012 22:21, Charles Davis <cdavis(a)mymail.mines.edu> a écrit :
On Mar 23, 2012, at 3:09 PM, Nicolas Le Cam wrote:
Le 23 mars 2012 21:41, Lauri Kenttä <lauri.kentta(a)gmail.com> a écrit :
--- dlls/mscoree/mscoree_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/mscoree/mscoree_main.c b/dlls/mscoree/mscoree_main.c index 1aa120f..0ebc813 100644 --- a/dlls/mscoree/mscoree_main.c +++ b/dlls/mscoree/mscoree_main.c @@ -359,7 +359,7 @@ HRESULT WINAPI GetRequestedRuntimeInfo(LPCWSTR pExe, LPCWSTR pwszVersion, LPCWST
HRESULT WINAPI GetRequestedRuntimeVersion(LPWSTR pExe, LPWSTR pVersion, DWORD cchBuffer, DWORD *dwlength) { - TRACE("(%s, %p, %d, %p)\n", debugstr_w(pExe), debugstr_w(pExe), cchBuffer, dwlength); + TRACE("(%s, %p, %d, %p)\n", debugstr_w(pExe), pVersion, cchBuffer, dwlength);
if(!dwlength) return E_POINTER; -- 1.7.9.4
Hi Lauri,
Should be %s debugstr_w(pVersion) IMHO. No, that's an out parameter. (It's hard to tell, because the in parameter pExe is of type LPWSTR instead of LPCWSTR.)
Chip
My bad, thanks for the explanation ! -- Nicolas Le Cam
participants (2)
-
Charles Davis -
Nicolas Le Cam