[PATCH 0/1] MR221: comctl32: Fix integer overflow in DPA_Search.

[Jinoh Kang (＠iamahuman)]

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com>

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/221

[PATCH 1/1] comctl32: Fix integer overflow in DPA_Search.

[Jinoh Kang]

From: Jinoh Kang <jinoh.kang.kr(a)gmail.com>

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com>
---
 dlls/comctl32/dpa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/comctl32/dpa.c b/dlls/comctl32/dpa.c
index b8d23f6cafa..aa9a045e516 100644
--- a/dlls/comctl32/dpa.c
+++ b/dlls/comctl32/dpa.c
@@ -859,7 +859,7 @@ INT WINAPI DPA_Search (HDPA hdpa, LPVOID pFind, INT nStart,
         r = hdpa->nItemCount - 1;
         lpPtr = hdpa->ptrs;
         while (r >= l) {
-            x = (l + r) / 2;
+            x = l + (r - l) / 2;
             n = (pfnCompare)(pFind, lpPtr[x], lParam);
             if (n == 0)
                 return x;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/221

[PATCH 0/1] MR221: comctl32: Fix integer overflow in DPA_Search. - approved

[Zhiyi Zhang (＠zhiyi)]

This merge request was approved by Zhiyi Zhang.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/221