Re: [PATCH 2/4] ddraw/tests: Add EXCLUSIVE->NORMAL coop level switching tests

[Henri Verbeet]

On 21 May 2013 13:18, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> +static void test_coop_level_versions(void)
> It may make more sense to move that to ddraw2.c and ddraw4.c instead.
> (IIRC you can't QI a ddraw1 interface from ddraw7.)

[PATCH 2/4] ddraw/tests: Add EXCLUSIVE->NORMAL coop level switching tests

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-05-21 16:03, schrieb Henri Verbeet:
> On 21 May 2013 13:18, Stefan Dösinger <stefan(a)codeweavers.com>
> wrote:
> > +static void test_coop_level_versions(void)
> > It may make more sense to move that to ddraw2.c and ddraw4.c
> > instead.
> > The reasoning behind putting this in ddraw1 is that ddraw1 has the
> > behavior that differs from the others.
> (IIRC you can't QI a ddraw1 interface from ddraw7.)
> ddraw1<->ddraw7 works fine, ddraw{1-4}->d3d7 and ddraw7->{d3d1-3}
> doesn't work.

I'll look into your comments for the actual patch tomorrow.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRm8ZVAAoJEN0/YqbEcdMwe3sQAIOeXETnqbHU/9l67iM+omSK
tjFevbqdMlpCF7IzeVGQ2kYeRPEPxair05P97vp48c46g/XZf2e0WvSFs3TVZaPy
OOjFSKxoDtn3S0gLcXCcrjs6MLL9sP6K7emi1Eu+apKdMV2z1uEHZnV7daU4ZAxs
JNRxvRXyEBS0UXRI0cYW5+QDQ0SPLYi4irqv3j8K+Em6HQSHm3W3fzafip5ucAbA
zJgBiAxKjbVOgQWZ7dcb5PU3zgyUuRKtEs3X5dteQy1rWstRWIUGbjgN7qNMcPy/
imN+pcHknbWiCdgHY+nj1A7nxh0m4HKKT/77aZj16TZTEJFXhNW768lQ+f0ZOJwm
Hf/kbL3p+pA2LDM/jQ0C5g9s1sKkctMfRNmJDj0VThFMkKIpuoGlFzDuwAVgs++X
tMeW2SAcgx3qW+zIMNGQcKON6L8rslRP5ZzkFukSsCC2hQ3dOfcOAM5dzRzEQXku
WovU2hheYSOqXWwO+k80QlNMXLTX2qV+6+8ONnmwY4pdHgAXwIddKYcIRhOKofRu
pJFHVJEtdi3utmba2/9RMIosQVdrcXmEDqGazbpdTY9VuJQXlpeQ0xdycpwsqPxR
4zJaG0rMoosg/MmW5o7CKE9M1lb1kMiK6i1xfVbxSLviPlZaJGDGfFsxhUfmsorJ
6cgiD8bTCBj3Z44SygWX
=jVym
-----END PGP SIGNATURE-----

[PATCH 2/4] ddraw/tests: Add EXCLUSIVE->NORMAL coop level switching tests

[Henri Verbeet]

On 21 May 2013 21:09, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
> Am 2013-05-21 16:03, schrieb Henri Verbeet:
> > On 21 May 2013 13:18, Stefan Dösinger <stefan(a)codeweavers.com>
> > wrote:
> > > +static void test_coop_level_versions(void)
> > > It may make more sense to move that to ddraw2.c and ddraw4.c
> > > instead.
> > > The reasoning behind putting this in ddraw1 is that ddraw1 has the
> > > behavior that differs from the others.

Yeah, I figured, but you're actually testing ddraw2 behaviour there,
and not covering ddraw4 and ddraw7 at all.