[PATCH 1/5] winevulkan: Move vkGetPhysicalDeviceSurfacePresentModesKHR to a private thunk
16 Jul
16 Jul
8:12 p.m.
I don't think this is necessary. See Brendan's comment on patch 5/5. Also for what it's worth, I think it would have been fine to have this and patch 2/5 combined into one change, maybe even patch 3/5 also, since you're just doing preparatory work for patch 5/5. Also, while it's not really enforced strongly (at least for winevulkan patched) it's generally preferable to leave generated changes out of the patches. For the small stuff like this, it's fine, it's just more cumbersome for larger changes where new enums/extensions/functions/structs are being added. Thanks, Liam Middlebrook On 7/16/20 12:41 AM, Joshua Ashton wrote:
1982
Age (days ago)
1982
Last active (days ago)
1 comments
2 participants
participants (2)
-
Joshua Ashton -
Liam Middlebrook