Re: [PATCH 2/3] include/wmsdkidl.idl: Add more interfaces

[Alex Henrie]

-    WMT_CODECINFO_UNKNOWN = 0xFFFFFFFF,
+    WMT_CODECINFO_UNKNOWN = 0xffffffff,

I think this qualifies as a gratuitous formatting change.

+    HRESULT GetBandwidth(   [out] DWORD *bitrate,
+                            [out] DWORD *buffer );
+
+    HRESULT SetBandwidth(   [in] DWORD bitrate,
+                            [in] DWORD buffer );

The extra spaces after the left parentheses look like a mistake; they
don't match the format in the rest of the file.

+    HRESULT GetBandwidthSharing( [in] DWORD index,
+                                [out] IWMBandwidthSharing **bandwidth );

+    HRESULT GetExpectedPacketCount( [in] QWORD duration,
+                                    [out] QWORD *packets );

+    HRESULT SetDRMProperty( [in] const WCHAR *name, [in]
WMT_ATTR_DATATYPE type,
+                            [in, size_is( length )] const BYTE *value,
+                            [in] WORD length );

+    HRESULT GetDRMProperty( [in] const WCHAR *name, [out]
WMT_ATTR_DATATYPE* type,
+                            [out, size_is( *length )]   BYTE *value,
+                            [in, out]   WORD *length );

Again, pick a whitespace style and stick to it. In particular, decide
whether you want to break the line after each variable or after
reaching 80, 100, or 120 characters.

-Alex

[PATCH 2/3] include/wmsdkidl.idl: Add more interfaces

[Dmitry Timoshkov]

Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> +    HRESULT GetBandwidth(   [out] DWORD *bitrate,
> +                            [out] DWORD *buffer );
> +
> +    HRESULT SetBandwidth(   [in] DWORD bitrate,
> +                            [in] DWORD buffer );
>
> The extra spaces after the left parentheses look like a mistake; they
> don't match the format in the rest of the file.

Because everything was directly copy-pasted from appropriate PSDK headers.

-- 
Dmitry.

[PATCH 2/3] include/wmsdkidl.idl: Add more interfaces

[Alex Henrie]

2017-05-09 23:25 GMT-06:00 Dmitry Timoshkov <dmitry(a)baikal.ru>:
> Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> > +    HRESULT GetBandwidth(   [out] DWORD *bitrate,
> > +                            [out] DWORD *buffer );
> > +
> > +    HRESULT SetBandwidth(   [in] DWORD bitrate,
> > +                            [in] DWORD buffer );
> >
> > The extra spaces after the left parentheses look like a mistake; they
> > don't match the format in the rest of the file.
>
> Because everything was directly copy-pasted from appropriate PSDK headers.

Even if the original files are ugly, ours don't have to be. I'm not
going to sign off on copy-pasted headers.

-Alex

[PATCH 2/3] include/wmsdkidl.idl: Add more interfaces

[Austin English]

On May 10, 2017 00:36, "Alex Henrie" <alexhenrie24(a)gmail.com> wrote:

2017-05-09 23:25 GMT-06:00 Dmitry Timoshkov <dmitry(a)baikal.ru>:
> Alex Henrie <alexhenrie24(a)gmail.com> wrote:
> > +    HRESULT GetBandwidth(   [out] DWORD *bitrate,
> > +                            [out] DWORD *buffer );
> > +
> > +    HRESULT SetBandwidth(   [in] DWORD bitrate,
> > +                            [in] DWORD buffer );
> >
> > The extra spaces after the left parentheses look like a mistake; they
> > don't match the format in the rest of the file.
>
> Because everything was directly copy-pasted from appropriate PSDK headers.

Even if the original files are ugly, ours don't have to be. I'm not
going to sign off on copy-pasted headers.

-Alex


Fyi, copy/pasted headers aren't acceptable in Wine, regardless of
maintainer sign off.