Re: widl [1/4]: Fix NdrConformantArrayUnmarshall calls in generated code

[Robert Shearman]

Dan Hipschman wrote:
> This series of four patches allow gcc to compile the proxy file that widl
> generates for oaidl.idl.  This first patch fixes the number and types of
> arguments widl generates for NdrConformantArrayUnmarshall calls.
>
> ChangeLog:
> * Generate the correct args for NdrConformantArrayUnmarshall in proxy code

Hi Dan,

It might be better to reuse the code in typegen.c rather than 
maintaining two different pieces of code that essentially do the same job.

-- 
Rob Shearman

widl [1/4]: Fix NdrConformantArrayUnmarshall calls in generated code

[Dan Hipschman]

On Wed, Aug 16, 2006 at 12:27:48PM +0100, Robert Shearman wrote:
> It might be better to reuse the code in typegen.c rather than 
> maintaining two different pieces of code that essentially do the same job.

I was just trying to be consistent with what was already in proxy.c.  The
next thing I was planning to do was to use the FormatString stuff from
typegen.c in proxy.c, so maybe while I'm doing that I can clean up all of
proxy.c to use what's available in typegen.c.

widl [1/4]: Fix NdrConformantArrayUnmarshall calls in generated code

[Robert Shearman]

Dan Hipschman wrote:
> On Wed, Aug 16, 2006 at 12:27:48PM +0100, Robert Shearman wrote:
> > It might be better to reuse the code in typegen.c rather than 
> > maintaining two different pieces of code that essentially do the same job.
>
> I was just trying to be consistent with what was already in proxy.c.  The
> next thing I was planning to do was to use the FormatString stuff from
> typegen.c in proxy.c, so maybe while I'm doing that I can clean up all of
> proxy.c to use what's available in typegen.c.

Sounds good. I was just making sure that you weren't going to duplicate 
some work that had already been done, but it sounds like you know 
exactly what you want to do here.

-- 
Rob Shearman