Re: [PATCH v4 3/20] ntoskrnl.exe: Implement loading plug and play devices

[Sebastian Lackner]

On 04.09.2016 03:12, Aric Stewart wrote:
> +    WCHAR buffer[sizeof(KEY_VALUE_PARTIAL_INFORMATION) + MAX_SERVICE_NAME * sizeof(WCHAR)];

I just noticed that the buffer size is wrong here. It should be something like:

char buffer[FIELD_OFFSET( KEY_VALUE_PARTIAL_INFORMATION, Data[MAX_SERVICE_NAME * sizeof(WCHAR)] )];

After this change I am basically fine, but the function is not really used before
patch [9/20] in your series. To make sure all pieces work together as expected I
would prefer to wait with my signoff until more pieces of winebus have been accepted.

By the way, as already mentioned on IRC, there is no need to have all ~20 patches
pending on the wine-patches website. It would be better to focus on a small subset
of about 5 patches at a time, otherwise it gets really difficult to figure out how
they are supposed to apply (126325 fails for example). If you want to share a
fully working version, it would be better to provide tarballs on wine-devel imho.

Regards,
Sebastian