Re: [PATCH 6/6] wined3d: Implement basic volume location management (try 2)

[Henri Verbeet]

On 22 August 2013 14:57, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> +            if (volume->locations & WINED3D_LOCATION_DISCARDED)
> +            {
> +                TRACE("Volume previously discarded, nothing to do.\n");
> +                wined3d_volume_invalidate_location(volume, WINED3D_LOCATION_DISCARDED);
> +            }
> I don't think the location invalidation here is strictly required,
> although it probably doesn't hurt much in practice. (I.e., consider
> the sequence DISCARD, load SYSMEM, load TEXTURE_RGB. There's no real
> reason the RGB load needs to do an upload from SYSMEM in that case,
> although it's perhaps not something that's going to happen much in
> practice either way.)
> +            wined3d_volume_validate_location(volume, WINED3D_LOCATION_SYSMEM);
> You could probably just have a
> wined3d_volume_validate_location(volume, location); at the end of the
> function and return from the default case instead. That's not
> something I feel strongly about though.

[PATCH 6/6] wined3d: Implement basic volume location management (try 2)

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-08-22 15:33, schrieb Henri Verbeet:
> On 22 August 2013 14:57, Stefan Dösinger <stefan(a)codeweavers.com>
> wrote:
> > +            if (volume->locations & WINED3D_LOCATION_DISCARDED) 
> > +            { +                TRACE("Volume previously
> > discarded, nothing to do.\n"); +
> > wined3d_volume_invalidate_location(volume,
> > WINED3D_LOCATION_DISCARDED); +            }
> > I don't think the location invalidation here is strictly required, 
> > although it probably doesn't hurt much in practice. (I.e.,
> > consider the sequence DISCARD, load SYSMEM, load TEXTURE_RGB.
> > There's no real reason the RGB load needs to do an upload from
> > SYSMEM in that case, although it's perhaps not something that's
> > going to happen much in practice either way.)
> > Ya, this is a pretty academic issue. The only situation I can think of
> > that would trigger this is a read-only map of a newly created volume.
> > In this case the application is most likely buggy and writes data and
> > wants it uploaded.

My gut feeling is to keep it the way it is. The combination of a valid
location and LOCATION_DISCARDED being set is somewhat unintuitive and
I'd prefer to avoid it.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSFhinAAoJEN0/YqbEcdMwWtIP/Ar/RY/qEmuDwuiIbMw/rOqr
nPkGYNaLvLJE8YDfAXcCWFkElMc6r5d/VZ5ljbY9606gJoytI61zghqvJ5+oyhbv
vyUbDeL4IX6o/71QMmc31fkATb7zpClESwKmG43xzktIpFurv5BzK/8JPvmVTn1J
Lzab4LNNhBDwYXZMDk7lJbmfivk3gNDAR9bPT1OuRxZlZkyOKwcnP3KujeXHu4LT
RnBSsWq+RunH5YawS1SJmEYziLszLhpKcOKO6sMqVD85nIt5wmo/UAUloigYLXCT
9uJ7BAaJC7vS65m+rwbaxEzK8RT5jQM7MmyRTBOmMEZ7azkU+LaJ8tdNJVroGiQs
B178SAPUotxUkQ8Y+trjuFfLBBhiEKs/YoYJ7O6/GChJ8Os7Sq2MkoSYsyIF3cEc
n4NokEXihwmISd4cZ7wMcsLxcACDQcuweVwvFLsDD3BBuM3tOCeMXOvTEuIp454d
4b3yd6FP4KJLG3OEs0ritaARfU8pyBa70Wg3KmtFQ41QilzmB0lnOEPYfHDOQmMA
nE44c8vZSe7vCMhgWowllv+el0KdRNW8f5WL/0+e/2LJqNmdqUlmG3p2CYaZls81
1hzSnMIox8LB1PLLnRZADjYiVUApQ2c+VDDOkFWH9rCJTE8usYl0gwoupgbmAXex
3gf85pZfNQqKWSYyk/8v
=8ZRH
-----END PGP SIGNATURE-----