Re: [PATCH 2/4] d3dxof: Fix file types checks + tests
On 03/01/2010 09:36 AM, Christian Costa wrote:
---
dlls/d3dxof/d3dxof.c | 39 ++++++++++++++------- dlls/d3dxof/tests/d3dxof.c | 82 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 109 insertions(+), 12 deletions(-)
Hi Christian, This introduces test failures on several platforms: http://test.winehq.org/data/tests/d3dxof:d3dxof.html Could you have a look? I don't know if you have an account on winetestbot as that would give you some nice exposure to several Windows OS versions. -- Cheers, Paul.
Paul Vriens a écrit :
On 03/01/2010 09:36 AM, Christian Costa wrote:
---
dlls/d3dxof/d3dxof.c | 39 ++++++++++++++------- dlls/d3dxof/tests/d3dxof.c | 82 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 109 insertions(+), 12 deletions(-)
Hi Christian,
This introduces test failures on several platforms:
http://test.winehq.org/data/tests/d3dxof:d3dxof.html
Could you have a look?
I don't know if you have an account on winetestbot as that would give you some nice exposure to several Windows OS versions.
Hi Paul, I will look at it. I've already an account. I use it now for testing because I don't have any Windows box at home. Christian
On 03/01/2010 11:48 PM, Christian Costa wrote:
Paul Vriens a écrit :
On 03/01/2010 09:36 AM, Christian Costa wrote:
---
dlls/d3dxof/d3dxof.c | 39 ++++++++++++++------- dlls/d3dxof/tests/d3dxof.c | 82 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 109 insertions(+), 12 deletions(-)
Hi Christian,
This introduces test failures on several platforms:
http://test.winehq.org/data/tests/d3dxof:d3dxof.html
Could you have a look?
I don't know if you have an account on winetestbot as that would give you some nice exposure to several Windows OS versions.
Hi Paul,
I will look at it. I've already an account. I use it now for testing because I don't have any Windows box at home.
Christian
Hi Christian, The attached patch fixes the tests. Does that make sense? -- Cheers, Paul.
On 03/05/2010 10:06 AM, Paul Vriens wrote:
On 03/01/2010 11:48 PM, Christian Costa wrote:
Paul Vriens a écrit :
On 03/01/2010 09:36 AM, Christian Costa wrote:
---
dlls/d3dxof/d3dxof.c | 39 ++++++++++++++------- dlls/d3dxof/tests/d3dxof.c | 82 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 109 insertions(+), 12 deletions(-)
Hi Christian,
This introduces test failures on several platforms:
http://test.winehq.org/data/tests/d3dxof:d3dxof.html
Could you have a look?
I don't know if you have an account on winetestbot as that would give you some nice exposure to several Windows OS versions.
Hi Paul,
I will look at it. I've already an account. I use it now for testing because I don't have any Windows box at home.
Christian
Hi Christian,
The attached patch fixes the tests.
Not quite, only on XP and W2K3 boxes so it seems. I also see that one of the winetestbox boxes (W7PRO) switches between 1 and 3 errors? -- Cheers, Paul.
It seems even if the file is empty a valid mszip header is needed. Does using "\x9a\x10\x00\x00\x8a\x10\x00\x00" or "\x9a\x10\x00\x00\x8a\x10\x02\x00CK" instead of "\n" help ?
Message du 05/03/10 10:15 De : "Paul Vriens" A : "Christian Costa" Copie à : wine-devel(a)winehq.org Objet : Re: [PATCH 2/4] d3dxof: Fix file types checks + tests
On 03/05/2010 10:06 AM, Paul Vriens wrote:
On 03/01/2010 11:48 PM, Christian Costa wrote:
Paul Vriens a écrit :
On 03/01/2010 09:36 AM, Christian Costa wrote:
---
dlls/d3dxof/d3dxof.c | 39 ++++++++++++++------- dlls/d3dxof/tests/d3dxof.c | 82 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 109 insertions(+), 12 deletions(-)
Hi Christian,
This introduces test failures on several platforms:
http://test.winehq.org/data/tests/d3dxof:d3dxof.html
Could you have a look?
I don't know if you have an account on winetestbot as that would give you some nice exposure to several Windows OS versions.
Hi Paul,
I will look at it. I've already an account. I use it now for testing because I don't have any Windows box at home.
Christian
Hi Christian,
The attached patch fixes the tests.
Not quite, only on XP and W2K3 boxes so it seems.
I also see that one of the winetestbox boxes (W7PRO) switches between 1 and 3 errors?
-- Cheers,
Paul.
On 03/05/2010 11:25 AM, Christian Costa wrote:
It seems even if the file is empty a valid mszip header is needed.
Does using "\x9a\x10\x00\x00\x8a\x10\x00\x00" or "\x9a\x10\x00\x00\x8a\x10\x02\x00CK" instead of "\n" help ?
Nope, doesn't help. Now it fails on all platforms. -- Cheers, Paul.
Does these ones "\x10\x00\x00\x00\x00\x00\x00\x00" or "\x10\x00\x00\x00\x00\x00\x02\x00CK" work better ? If not I think it's better to comment out these tests until I find a better header.
Message du 05/03/10 12:03 De : "Paul Vriens" A : "Christian Costa" Copie à : wine-devel(a)winehq.org Objet : Re: [PATCH 2/4] d3dxof: Fix file types checks + tests
On 03/05/2010 11:25 AM, Christian Costa wrote:
It seems even if the file is empty a valid mszip header is needed.
Does using "\x9a\x10\x00\x00\x8a\x10\x00\x00" or "\x9a\x10\x00\x00\x8a\x10\x02\x00CK" instead of "\n" help ?
Nope, doesn't help. Now it fails on all platforms.
-- Cheers,
Paul.
On 03/05/2010 01:06 PM, Christian Costa wrote:
Does these ones "\x10\x00\x00\x00\x00\x00\x00\x00" or "\x10\x00\x00\x00\x00\x00\x02\x00CK" work better ?
If not I think it's better to comment out these tests until I find a better header.
Again, fails on all platforms. -- Cheers, Paul.
participants (2)
-
Christian Costa -
Paul Vriens