Re: [PATCH 1/6] wined3d: Remove the version parameter (try 2).

[Henri Verbeet]

On 20 March 2014 12:28, Stefan Dösinger <stefan(a)codeweavers.com> wrote:
> +    if (!(caps.ddraw_caps.caps & WINEDDCAPS_3D))
> +    {
> +        WARN("Created a wined3d object without 3D support.\n");
> +        wined3d_decref(d3d8->wined3d);
> +        goto done;
> +    }
> I don't think that really matches Windows. Going by the testbot
> results, I think creating a D3D object should succeed, and creating a
> (hardware) device should fail.

[PATCH 1/6] wined3d: Remove the version parameter (try 2).

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-03-20 12:46, schrieb Henri Verbeet:
> I don't think that really matches Windows. Going by the testbot 
> results, I think creating a D3D object should succeed, and
> creating a (hardware) device should fail.
> Do we care enough about this? The behavior of my patch matches the
> behavior if OpenGL is not available. To change this we'd have to put
> this check in every d3d object method (or rather its wined3d
> counterpart) that accepts a device type. A quick search through our
> bug database didn't bring up any application that fails with the
> current handling and would otherwise do something reasonable if we
> returned an error during device creation.
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.22 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTKt7VAAoJEN0/YqbEcdMwvukP/2HOlconJnHL/j/BdveDDUHX
jUvFBVZ9wHU6Zebwcx5FBm17LeGIE62q5xzB2pfVym52QfACumPygx7kqqUI9DGy
0E0aKWES/WNM6nogX1RUEbpFckVqUmONKWFgNNvIYi3H8PfPlIKe+sdYwaLmnIkd
6GBKjpMtUb/2ArL3PNRiwTYhhxr1bR1UyHbcQjJC8pH/1elRZYJc7ISJleAvg6wM
oQZkzURc6KIS3MtfXdoHSGXhUp6P6/aJGPkJzIAiD6ANSE6s2c7MGadSzu3ITD4v
s6tkWQUQwQBu9o5d1OIAuWhT4MHPJV+QIX2Ble+W99fom/jqxO0+g7Dqx/+h+bKV
tZcHyccI+VfcU8GmIC0tZplEcy0QD4hzbp0wZa0gMHZylw/V7Xf/gFzU91qI+1HR
IUy6X/7DvEfDtIxbqJAYtMNs27T7sE2OkMmJURheT+8lk+6G2FqCVgg/OMkHWIlX
xVVPjmWlJM+YL0G3Csw0qgXV4T/CRsczB0xkqKyGA3qcR/PD+chtDCMbzF92wdv+
3QXp3s9yuMorqXI5xVSecF487tfCcG6tY45Kd+oQ2avq5Y5yVDk5mQbFzZxWAGgl
EroHZCkoEIhFuUb0aiStN3wVONRVc+aH6F2ZHF0aPziijMS1Zpa0/qgGE7Joluxe
Ja734UvcYXf0N1xJL95P
=HgH8
-----END PGP SIGNATURE-----

[PATCH 1/6] wined3d: Remove the version parameter (try 2).

[Henri Verbeet]

On 20 March 2014 13:28, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
> Am 2014-03-20 12:46, schrieb Henri Verbeet:
> > I don't think that really matches Windows. Going by the testbot
> > results, I think creating a D3D object should succeed, and
> > creating a (hardware) device should fail.
> > Do we care enough about this? The behavior of my patch matches the
> > behavior if OpenGL is not available.
> > Perhaps not quite enough to fix all the device type checks right now,
> > but I certainly don't think we should add extra code to make the
> > behaviour worse either.

[PATCH 1/6] wined3d: Remove the version parameter (try 2).

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-03-20 14:06, schrieb Henri Verbeet:
> Perhaps not quite enough to fix all the device type checks right
> now, but I certainly don't think we should add extra code to make
> the behaviour worse either.
> So you'd prefer to just ignore the possibly set WINED3D_NO3D flag in
> d3d8/9/dxgi? The result of that is (at least in the tests) a crash
> later. I'm fine with that, just mentioning it.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTKvDMAAoJEN0/YqbEcdMwbqsP/RYLxwtWy5m0d/+T3Or3tzn3
0Zet58ss1smMKZ3jRAxAU9S4M1jDgWLzF1DEdP4MMNbS6YcgcClJuKf+xMCVGt6f
8Lthlc5X8RUw2P9UlgOjP99qDITwncVllO68IyA1oVEDZ7eCrUHht1Xea8LPU9LP
1LGq06E/8L60D8vtZyVWYwhdNGdkL2hA3Kay3f20kJA1Z+LqA4VoyXR+JKKyeidN
4jtISrRhf5+/MzZj0aHd+7GXCdBCRR019t+5GAz+hC81axM8qtbuLYDqmJ+jp0Hh
jnbdnjZqrLz4NgrZYA/AQtj70eNBuKOx3De0vVx/OMcfrVE77Kh17ArNlrs5u7VN
oHtALoCQIQHgYpoLxroZw3P8V6KKFnwIr918Kvf/2nlwe6lANFjCap2bq5EcgWPv
R0NPPZBgFeOR8hAw1khZMRtd+GjURm2EuZsb5C8wQCd2ySJC84+1nVx0m71sw7u9
LKzpKJv0bnIRwDHKzAGzK0Xz5iI0pxAdr5Dk2o9XLwYgS2uLhGzUhCZ6sMcE0Ymj
CAWEJxKdsvayjQfIsadruSzRJVaA+9UNQ0voP2UeX13Ld69fGoxcBXqoksEHv1pm
WLjh8Pk/c+v2mFWAjzCSgZ/LzyIMa2wY8PCv/r/FPIuRoeaPNMiHCzUg7ecIS7AZ
zHkm0jaiuVVZyJ/f1cdo
=SeBd
-----END PGP SIGNATURE-----

[PATCH 1/6] wined3d: Remove the version parameter (try 2).

[Henri Verbeet]

On 20 March 2014 14:44, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 2014-03-20 14:06, schrieb Henri Verbeet:
> > Perhaps not quite enough to fix all the device type checks right
> > now, but I certainly don't think we should add extra code to make
> > the behaviour worse either.
> > So you'd prefer to just ignore the possibly set WINED3D_NO3D flag in
> > d3d8/9/dxgi? The result of that is (at least in the tests) a crash
> > later. I'm fine with that, just mentioning it.

Which test is that?

[PATCH 1/6] wined3d: Remove the version parameter (try 2).

[Stefan Dösinger]

Am 20.03.2014 16:45 schrieb "Henri Verbeet" <hverbeet(a)gmail.com>:
> On 20 March 2014 14:44, Stefan Dösinger <stefandoesinger(a)gmail.com> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Am 2014-03-20 14:06, schrieb Henri Verbeet:
> > > Perhaps not quite enough to fix all the device type checks right
> > > now, but I certainly don't think we should add extra code to make
> > > the behaviour worse either.
> > > So you'd prefer to just ignore the possibly set WINED3D_NO3D flag in
> > > d3d8/9/dxgi? The result of that is (at least in the tests) a crash
> > > later. I'm fine with that, just mentioning it.
>
> Which test is that?

I think it was some operator error by me. I could not reproduce it when I
tested before sending v3. It was the d3d8 visual test. It crashed during
device creation inside wined3d. I suspect I had a mismatched d3d8 and
wined3d build.