Re: [2/2] comctl32: tab.c The Item Interior should use HotTracking color not Hilight color (resend).

[Alexandre Julliard]

Anatoly Lyutin <vostok(a)etersoft.ru> writes:
> @@ -1633,7 +1633,7 @@ TAB_DrawItemInterior(const TAB_INFO *inf
>        SetTextColor(hdc, (((lStyle & TCS_HOTTRACK) && (iItem == infoPtr->iHotTracked) 
>                            && !(lStyle & TCS_FLATBUTTONS)) 
>                          | (TAB_GetItem(infoPtr, iItem)->dwState & TCIS_HIGHLIGHTED)) ?
> -                        comctl32_color.clrHighlight : comctl32_color.clrBtnText);
> +                        comctl32_color.clrHotTrackingColor : comctl32_color.clrBtnText);

Shouldn't you distinguish between TCS_HOTTRACK and TCIS_HIGHLIGHTED
here?

-- 
Alexandre Julliard
julliard(a)winehq.org

[2/2] comctl32: tab.c The Item Interior should use HotTracking color not Hilight color (resend).

[Anatoly Lyutin]

Alexandre Julliard wrote:
> > @@ -1633,7 +1633,7 @@ TAB_DrawItemInterior(const TAB_INFO *inf
> >        SetTextColor(hdc, (((lStyle & TCS_HOTTRACK) && (iItem == infoPtr->iHotTracked) 
> >                            && !(lStyle & TCS_FLATBUTTONS)) 
> >                          | (TAB_GetItem(infoPtr, iItem)->dwState & TCIS_HIGHLIGHTED)) ?
> > -                        comctl32_color.clrHighlight : comctl32_color.clrBtnText);
> > +                        comctl32_color.clrHotTrackingColor : comctl32_color.clrBtnText);
>
> Shouldn't you distinguish between TCS_HOTTRACK and TCIS_HIGHLIGHTED
> here?
> I could not find anywhere documentation about TCIS_HIGHLIGHTED...
> I just changed the registry value "HotTrackingColor" in Windows and 
> after that I have seen that the tab flashes HotTracking color not Hilight.

Please tell me right way to fix this mistake.


-- 
Best regards
	Anatoly Lyutin.