Re: [PATCH] wined3d: Only display a fixme when software processing is requested in wined3d_device_set_software_vertex_processing.

[Austin English]

On Thu, May 16, 2013 at 2:26 PM, Christian Costa <titan.costa(a)gmail.com> wrote:
> Also remove fixme in wined3d_device_get_software_vertex_processing since it does what it is supposed to do.
> ---
>  dlls/wined3d/device.c |   12 ++----------
>  1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c
> index 47da78b..89fc525 100644
> --- a/dlls/wined3d/device.c
> +++ b/dlls/wined3d/device.c
> @@ -4281,9 +4281,9 @@ void CDECL wined3d_device_set_software_vertex_processing(struct wined3d_device *
>
> TRACE("device %p, software %#x.\n", device, software);
>
> -    if (!warned)
> +    if (software && !warned)
>      {
> -        FIXME("device %p, software %#x stub!\n", device, software);
> +        FIXME("Software vertex processing not supported. Fake it and use harware one.");
>          warned = TRUE;

Typo, should be hardware.

--
-Austin

[PATCH] wined3d: Only display a fixme when software processing is requested in wined3d_device_set_software_vertex_processing.

[Christian Costa]

2013/5/17 Austin English <austinenglish(a)gmail.com>
> On Thu, May 16, 2013 at 2:26 PM, Christian Costa <titan.costa(a)gmail.com>
> wrote:
> > Also remove fixme in wined3d_device_get_software_vertex_processing since
> > it does what it is supposed to do.
> > ---
> >  dlls/wined3d/device.c |   12 ++----------
> >  1 file changed, 2 insertions(+), 10 deletions(-)
> >
> > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c
> > index 47da78b..89fc525 100644
> > --- a/dlls/wined3d/device.c
> > +++ b/dlls/wined3d/device.c
> > @@ -4281,9 +4281,9 @@ void CDECL
> > wined3d_device_set_software_vertex_processing(struct wined3d_device *
> >
> > TRACE("device %p, software %#x.\n", device, software);
> >
> > -    if (!warned)
> > +    if (software && !warned)
> >      {
> > -        FIXME("device %p, software %#x stub!\n", device, software);
> > +        FIXME("Software vertex processing not supported. Fake it and
> > use harware one.");
> >          warned = TRUE;
>
> Typo, should be hardware.
>
> Ok. Thanks !
> Christian