Re: [PATCH 2/2] winegstreamer: Always run gstreamer callbacks on a Wine thread
Hello Andrew, On 01/11/2016 09:13 PM, Andrew Eikum wrote:
This gets winegstreamer with gstreamer-0.10 working for me again, fixing Bug 30557. However, gstreamer-0.10 is no longer developed and some distros don't ship it anymore. which distros are those? gstreamer-0.10 is still available in Fedora 23. I intend to pull this patch (or a version of it) into Stable. But I'd rather stick with the old gstreamer-0.10 then go to the new API; it is the smaller change.
I have more patches on top of this one to move winegstreamer to the gstreamer-1.0 API. See Bug 31836. In order to avoid dependency churn for packagers, I think it makes sense to apply them both during the same release, so I intend to send those patches after this one is accepted. If you prefer to review them all, I can send them all at once.
bye michael
On Tue, 12 Jan 2016, Michael Stefaniuc wrote:
Hello Andrew,
On 01/11/2016 09:13 PM, Andrew Eikum wrote:
This gets winegstreamer with gstreamer-0.10 working for me again, fixing Bug 30557. However, gstreamer-0.10 is no longer developed and some distros don't ship it anymore. which distros are those? gstreamer-0.10 is still available in Fedora 23.
GStreamer 1.0 came out in 2012 which means development shifted from 0.10 to 1.0 no later than that date. So GStreamer 0.10 has seen no improvements for at least 3 years while 1.x has seen continuous changes.
From the GStreamer FAQ: http://gstreamer.freedesktop.org/data/doc/gstreamer/head/faq/html/chapter-ge...
Q: So which GStreamer version should I get? A: You should download GStreamer-1.0. GStreamer-0.10 is end-of-life. So regardless of the distributions it's time for Wine to move to 1.0. But given the situation one has to expect distributions to drop support for 0.10 at some point. Indeed: Debian: https://lists.debian.org/debian-devel/2015/05/msg00335.html Ubuntu and other Debian derivatives will likely follow suite.
I intend to pull this patch (or a version of it) into Stable. But I'd rather stick with the old gstreamer-0.10 then go to the new API; it is the smaller change.
That said, I think fixing GStreamer 0.10 support in the current stable branch makes sense. And now that we have frequent (for some value of 'frequent') stable releases support for GStreamer 1.0 can go into the next stable release. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 145 = 1! + 4! + 5!
On Tue, Jan 12, 2016 at 11:25:53AM +0100, Michael Stefaniuc wrote:
Hello Andrew,
On 01/11/2016 09:13 PM, Andrew Eikum wrote:
This gets winegstreamer with gstreamer-0.10 working for me again, fixing Bug 30557. However, gstreamer-0.10 is no longer developed and some distros don't ship it anymore. which distros are those? gstreamer-0.10 is still available in Fedora 23.
Yes, Debian most notably.
I intend to pull this patch (or a version of it) into Stable. But I'd rather stick with the old gstreamer-0.10 then go to the new API; it is the smaller change.
I'm okay with that if you want to, but you will be enabling a DLL that was not enabled before, which can obviously cause regressions. See the "quartz" component in bugzilla (though not all of those are related to winegstreamer). Andrew
On 01/12/2016 02:42 PM, Andrew Eikum wrote:
On Tue, Jan 12, 2016 at 11:25:53AM +0100, Michael Stefaniuc wrote:
Hello Andrew,
On 01/11/2016 09:13 PM, Andrew Eikum wrote:
This gets winegstreamer with gstreamer-0.10 working for me again, fixing Bug 30557. However, gstreamer-0.10 is no longer developed and some distros don't ship it anymore. which distros are those? gstreamer-0.10 is still available in Fedora 23.
Yes, Debian most notably.
I intend to pull this patch (or a version of it) into Stable. But I'd rather stick with the old gstreamer-0.10 then go to the new API; it is the smaller change.
I'm okay with that if you want to, but you will be enabling a DLL that was not enabled before, which can obviously cause regressions. See the "quartz" component in bugzilla (though not all of those are related to winegstreamer). Uh? winegstreamer is already enabled, just prone to crashing. By cherry picking this change I'm actually fixing it.
That's why I don't want to pull in the change for 1.0 as in that case I enable winegstreamer for people without gstreamer 0.10. bye michael
On Tue, Jan 12, 2016 at 02:53:03PM +0100, Michael Stefaniuc wrote:
On 01/12/2016 02:42 PM, Andrew Eikum wrote:
On Tue, Jan 12, 2016 at 11:25:53AM +0100, Michael Stefaniuc wrote:
Hello Andrew,
On 01/11/2016 09:13 PM, Andrew Eikum wrote:
This gets winegstreamer with gstreamer-0.10 working for me again, fixing Bug 30557. However, gstreamer-0.10 is no longer developed and some distros don't ship it anymore. which distros are those? gstreamer-0.10 is still available in Fedora 23.
Yes, Debian most notably.
I intend to pull this patch (or a version of it) into Stable. But I'd rather stick with the old gstreamer-0.10 then go to the new API; it is the smaller change.
I'm okay with that if you want to, but you will be enabling a DLL that was not enabled before, which can obviously cause regressions. See the "quartz" component in bugzilla (though not all of those are related to winegstreamer). Uh? winegstreamer is already enabled, just prone to crashing. By cherry picking this change I'm actually fixing it.
I guess in theory. In practice, Arch, Debian, and Fedora all disable winegstreamer at configure-time. Picking across support for it into the stable branch might encourage them to build it. Like I said, I'm not opposed, just be warned. https://projects.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=... https://packages.debian.org/stretch/wine http://koji.fedoraproject.org/koji/buildinfo?buildID=710361 Andrew
participants (3)
-
Andrew Eikum -
Francois Gouget -
Michael Stefaniuc