Re: ole32/tests: remove a test, as it fails or hangs on Vista+

[Paul Vriens]

On 01/05/2010 08:05 PM, André Hentschel wrote:
> vista and 2k8: fails
> w7:            timeout
> ---
>   dlls/ole32/tests/clipboard.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/dlls/ole32/tests/clipboard.c b/dlls/ole32/tests/clipboard.c
> index 626d244..4a9e234 100644
> --- a/dlls/ole32/tests/clipboard.c
> +++ b/dlls/ole32/tests/clipboard.c
> @@ -1186,6 +1186,7 @@ static void test_flushed_getdata(void)
>          "got %08x\n", hr);
>       if(SUCCEEDED(hr)) ReleaseStgMedium(&med);
>
> +#if 0 /* broken on Vista+ */
>       InitFormatEtc(fmt, cf_another, 0xffff);
>       memset(&dm, 0, sizeof(dm));
>       dm.dmSize = sizeof(dm);
> @@ -1204,6 +1205,7 @@ static void test_flushed_getdata(void)
>       ok(hr == S_OK, "got %08x\n", hr);
>       ok(med.tymed == TYMED_ISTORAGE, "got %x\n", med.tymed);
>       if(SUCCEEDED(hr)) ReleaseStgMedium(&med);
> +#endif
>
> HeapFree(GetProcessHeap(), 0, fmt.ptd);

The test doesn't fail or hang on all Vista+ boxes though. There have 
been several attempts to fix these failures but I'm not sure just 
removing them is the best option.

Apart from that I think "if (0)" is preferred over "#if 0".

-- 
Cheers,

Paul.