Re: shell32: Implement ordinal 704, also known as GUIDFromStringW.

[Juan Lang]

Hi Hans,

+ 704 stdcall @(wstr ptr) SHELL32_704 # GUIDFromStringW

Out of curiosity, what's the reason for using SHELL32_704 as the name,
instead of GUIDFromStringW?
--Juan

shell32: Implement ordinal 704, also known as GUIDFromStringW.

[Hans Leidekker]

On Wednesday 14 January 2009 17:01:06 Juan Lang wrote:
> + 704 stdcall @(wstr ptr) SHELL32_704 # GUIDFromStringW
>
> Out of curiosity, what's the reason for using SHELL32_704 as the name,
> instead of GUIDFromStringW?

I just followed a pattern already there in shell32, I don't know the exact
rules that apply here, to be honest.

 -Hans

shell32: Implement ordinal 704, also known as GUIDFromStringW.

[Juan Lang]

> I just followed a pattern already there in shell32, I don't know the exact
> rules that apply here, to be honest.

I neither, I was seeking illumination.  In case there's an absence of
clear rules, I'd suggest the more readable GUIDFromStringW is better.
--Juan

shell32: Implement ordinal 704, also known as GUIDFromStringW.

[Austin English]

On Wed, Jan 14, 2009 at 10:15 AM, Hans Leidekker <hans(a)codeweavers.com> wrote:
> On Wednesday 14 January 2009 17:01:06 Juan Lang wrote:
> > + 704 stdcall @(wstr ptr) SHELL32_704 # GUIDFromStringW
> >
> > Out of curiosity, what's the reason for using SHELL32_704 as the name,
> > instead of GUIDFromStringW?
>
> I just followed a pattern already there in shell32, I don't know the exact
> rules that apply here, to be honest.
>
> -Hans

Stefan Leichter sent a patch in last week to rename SHELL32_526 to its
'pretty' name, 'SHFlushSFCache', see:

http://source.winehq.org/git/wine.git/?a=commitdiff;h=2ca9f2c5368f33137ac58d...

-- 
-Austin

shell32: Implement ordinal 704, also known as GUIDFromStringW.

[Alexandre Julliard]

Hans Leidekker <hans(a)codeweavers.com> writes:
> On Wednesday 14 January 2009 17:01:06 Juan Lang wrote:
> > + 704 stdcall @(wstr ptr) SHELL32_704 # GUIDFromStringW
> >
> > Out of curiosity, what's the reason for using SHELL32_704 as the name,
> > instead of GUIDFromStringW?
>
> I just followed a pattern already there in shell32, I don't know the exact
> rules that apply here, to be honest.

If there's a known official name you should use it, and most likely make
it a -noname export.

-- 
Alexandre Julliard
julliard(a)winehq.org

shell32: Implement ordinal 704, also known as GUIDFromStringW.

[Dmitry Timoshkov]

"Hans Leidekker" <hans(a)codeweavers.com> wrote:
> On Wednesday 14 January 2009 17:01:06 Juan Lang wrote:
> > + 704 stdcall @(wstr ptr) SHELL32_704 # GUIDFromStringW
> >
> > Out of curiosity, what's the reason for using SHELL32_704 as the name,
> > instead of GUIDFromStringW?
>
> I just followed a pattern already there in shell32, I don't know the exact
> rules that apply here, to be honest.

According to
http://www.geoffchappell.com/viewer.htm?doc=studies/windows/shell/shell32/hi...

shell32.704 GUIDFromStringW redirected to SHLWAPI in version 5.00 and higher 

-- 
Dmitry.