Re: kernel32: implement IsValidLocaleName (as a wrapper around IsValidLocale)

[Dmitry Timoshkov]

Austin English <austinenglish(a)gmail.com> wrote:
> +BOOL WINAPI IsValidLocaleName( LPCWSTR locale )
> +{
> +    LCID lcid;
> +    BOOL ret;
> +
> +    TRACE( "locale: %s\n", debugstr_w(locale) );
> +    lcid = LocaleNameToLCID( locale, 0 );
> +    ret = IsValidLocale( lcid, 0 );
> +    return ret;
> +}

Avoiding (useless) intermediate variables along with the word 'locale'
in the trace would be better IMO.

-- 
Dmitry.

kernel32: implement IsValidLocaleName (as a wrapper around IsValidLocale)

[Austin English]

On Tue, Jul 10, 2012 at 7:39 AM, Dmitry Timoshkov <dmitry(a)baikal.ru> wrote:
> Austin English <austinenglish(a)gmail.com> wrote:
> > +BOOL WINAPI IsValidLocaleName( LPCWSTR locale )
> > +{
> > +    LCID lcid;
> > +    BOOL ret;
> > +
> > +    TRACE( "locale: %s\n", debugstr_w(locale) );
> > +    lcid = LocaleNameToLCID( locale, 0 );
> > +    ret = IsValidLocale( lcid, 0 );
> > +    return ret;
> > +}
>
> Avoiding (useless) intermediate variables along with the word 'locale'
> in the trace would be better IMO.
>
> --
> Dmitry.

Fixed and resent the series, thanks for reviewing.

-- 
-Austin