Re: [3/3] user32/tests: Add tests for SendInput with unicode

[Dmitry Timoshkov]

"Andrew Eikum" <aeikum(a)codeweavers.com> wrote:
> ---
>  dlls/user32/tests/input.c |  210 
> +++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 210 insertions(+), 0 deletions(-)

It would be more natural and would simplify the code to add these
tests to msg.c.

Also, please try to avoid names like g_keyStatus, lastKeyDown,
UnicodeWndProc and similar. key_status, last_key_down, unicode_wnd_proc
look much more readable.

-- 
Dmitry.

[3/3] user32/tests: Add tests for SendInput with unicode

[Andrew Eikum]

Dmitry Timoshkov wrote:
> "Andrew Eikum" <aeikum(a)codeweavers.com> wrote:
> > ---
> >  dlls/user32/tests/input.c |  210 
> > +++++++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 210 insertions(+), 0 deletions(-)
>
> It would be more natural and would simplify the code to add these
> tests to msg.c.

I see your point and I'll take a look at it, but the tests aren't really 
testing messages.  They test SendInput, which already has tests that 
work similarly in input.c.  Messages are just the tool used to verify 
that SendInput is operating properly.

Thanks for your feedback
Andrew