re: [PATCH 1/2] oledb32: Implement support for converting to DBTYPE_I1.
30 May
2019
30 May
'19
8:35 a.m.
Hi Owen, + case DBTYPE_I1: + { + signed char *d = dst; + switch(src_type) + { + case DBTYPE_EMPTY: *d = 0; hr = S_OK; break; + case DBTYPE_I1: *d = *(signed char*)src; hr = S_OK; break; + case DBTYPE_I2: hr = VarI1FromI2(*(signed short*)src, d); hr = S_OK; break; Any reason you faking success here? Regards Alistair
30 May
30 May
8:49 a.m.
New subject: [PATCH 1/2] oledb32: Implement support for converting to DBTYPE_I1.
On 30/05/2019 09:35, Alistair Leslie-Hughes wrote:
+ case DBTYPE_I2: hr = VarI1FromI2(*(signed short*)src, d); hr = S_OK; break; Any reason you faking success here?
Good spot, that extra hr = S_OK shouldn't be there - will fix that. Thanks, Owen
2478
Age (days ago)
2478
Last active (days ago)
1 comments
2 participants
participants (2)
-
Alistair Leslie-Hughes -
Owen Rudge