Re: [2/4] rsaenh: Fixing a testfailure because Win7 seems to support salt with AES
Hi Andre, I don't object to this patch per se, but: - ok(!result && (GetLastError() == NTE_BAD_KEY || GetLastError() == ERROR_NO_TOKEN /* Win7 */), - "expected NTE_BAD_KEY or ERROR_NO_TOKEN, got %08x\n", GetLastError()); + todo_wine ok(broken(!result && GetLastError() == NTE_BAD_KEY) || result /* Win7 */, + "CryptGetKeyParam failed, got %08x\n", GetLastError()); Why don't you fix rsaenh while you're at it? It'd be an exceedingly easy patch. Look for KP_SALT in rsaenh.c, and you'll see what I mean. --Juan
Am 30.04.2010 19:52, schrieb Juan Lang:
Hi Andre, I don't object to this patch per se, but: - ok(!result && (GetLastError() == NTE_BAD_KEY || GetLastError() == ERROR_NO_TOKEN /* Win7 */), - "expected NTE_BAD_KEY or ERROR_NO_TOKEN, got %08x\n", GetLastError()); + todo_wine ok(broken(!result && GetLastError() == NTE_BAD_KEY) || result /* Win7 */, + "CryptGetKeyParam failed, got %08x\n", GetLastError());
Why don't you fix rsaenh while you're at it? It'd be an exceedingly easy patch. Look for KP_SALT in rsaenh.c, and you'll see what I mean. --Juan
next patch set ill do. as it has to be tested some more it is better to take some time which i just rarely have. thx -- Best Regards, André Hentschel
participants (2)
-
André Hentschel -
Juan Lang