re: old patch enabling visible icons in some applications
trueflyingsheep wrote:
why didn't it make it into the release?
Probably because there was an unsettled question: http://www.winehq.org/pipermail/wine-patches/2008-June/055490.html Please open a bug for this issue (if there isn't already one) and give a few names there for affected apps, as well as a link to the original patch, so we don't lose track of it. Thanks! - Dan
then lets just use the original code with the unrolled loop. whatever. just *please* put in one of the two versions so that we can see icons in office 2007, windows media player, regexbuddy,… if you want to know what is affected, just google for: fixme:xrender:X11DRV_AlphaBlend Ignoring SourceConstantAlpha for AC_SRC_ALPHA and i don’t know how to start a bug report and have other things to do tthan getting involved in wine development. i just don’t get why a working patch doesn’t get int 2009/8/9 Dan Kegel <dank(a)kegel.com>
trueflyingsheep wrote:
why didn't it make it into the release?
Probably because there was an unsettled question: http://www.winehq.org/pipermail/wine-patches/2008-June/055490.html
Please open a bug for this issue (if there isn't already one) and give a few names there for affected apps, as well as a link to the original patch, so we don't lose track of it.
Thanks! - Dan
2009/8/9 Philipp A. <trueflyingsheep(a)googlemail.com>
then lets just use the original code with the unrolled loop. whatever. just *please* put in one of the two versions so that we can see icons in office 2007, windows media player, regexbuddy,…
if you want to know what is affected, just google for: fixme:xrender:X11DRV_AlphaBlend Ignoring SourceConstantAlpha for AC_SRC_ALPHA
and i don’t know how to start a bug report and have other things to do tthan getting involved in wine development.
i just don’t get why a working patch doesn’t get int
2009/8/9 Dan Kegel <dank(a)kegel.com>
trueflyingsheep wrote:
why didn't it make it into the release?
Probably because there was an unsettled question: http://www.winehq.org/pipermail/wine-patches/2008-June/055490.html
Please open a bug for this issue (if there isn't already one) and give a few names there for affected apps, as well as a link to the original patch, so we don't lose track of it.
Thanks! - Dan
Well bug 8555 (http://bugs.winehq.org/show_bug.cgi?id=8555) is affected by that FIXME, so that can be a starting bug.
Well bug 8555 (http://bugs.winehq.org/show_bug.cgi?id=8555) is affected by that FIXME, so that can be a starting bug.
Well, i think, they don't like working apps. What on earth can i do to make somebody stop by and put the damn patch into the svn?
Philipp A. wrote:
Well bug 8555 (http://bugs.winehq.org/show_bug.cgi?id=8555) is affected by that FIXME, so that can be a starting bug.
Well, i think, they don't like working apps. What on earth can i do to make somebody stop by and put the damn patch into the svn?
Clean it up and make it functional including tests, if needed. James McKenzie
what do you mean with “clean it up”? i don’t see anything not-clean about it. and why is it nonfunctional in your opinion? and for testing: that’s what svn-versions are for, aren’t they? 2009/8/20 James McKenzie <jjmckenzie51(a)earthlink.net>
Philipp A. wrote:
Well bug 8555 (http://bugs.winehq.org/show_bug.cgi?id=8555) is affected by that FIXME, so that can be a starting bug.
Well, i think, they don't like working apps. What on earth can i do to make somebody stop by and put the damn patch into the svn?
Clean it up and make it functional including tests, if needed.
James McKenzie
2009/8/20 Philipp A. <trueflyingsheep(a)googlemail.com>:
what do you mean with “clean it up”? i don’t see anything not-clean about it. and why is it nonfunctional in your opinion? and for testing: that’s what svn-versions are for, aren’t they?
2009/8/20 James McKenzie <jjmckenzie51(a)earthlink.net>
Philipp A. wrote:
Well bug 8555 (http://bugs.winehq.org/show_bug.cgi?id=8555) is affected by that FIXME, so that can be a starting bug.
Well, i think, they don't like working apps. What on earth can i do to make somebody stop by and put the damn patch into the svn?
Clean it up and make it functional including tests, if needed.
James McKenzie
Phillip, firstly, please bottom-post on the mailing list. If the patch was not accepted there would have been a reason. Perhaps there was an obvious error in the code, perhaps the approach was wrong, perhaps it won't work in all cases. It also is possible that it doesn't match the behaviour of Windows, or if it does, it needs to be proved with a conformance test. Conformance tests are essential to prove that a.) The fix works, b.) It matches the behaviour on Windows and c.) a code change won't cause a regression in the future (because the test would flag that up). Just because it appears to give the correct result doesn't mean the patch isn't flawed in some other way, you can always hack a solution that would work in some cases but it won't be the right approach. So, if you want this patch to be accepted, then someone needs to take it up, they need to consult Alexandre Julliard in #winehackers to find out why he rejected it in the first place, then they need to fix any issues he has spotted and likely write a conformance test to prove the patch is correct. You've said you don't want to get involved in working on the patch itself, so you can find/make a bug report, link to this patch and explain in the report that the patch seems to fix it for you. Luke.
Well, i think, they don't like working apps. What on earth can i do to make somebody stop by and put the damn patch into the svn?
You can keep yelling on this list, and tell us how busy you are. We care. Really and truly we do. --Juan
participants (6)
-
Dan Kegel -
Jaime Rave -
James McKenzie -
Juan Lang -
Luke Benstead -
Philipp A.