Re: [PATCH 1/5] d3dx11: Use debugstr_a() to trace a user-supplied string.

[Henri Verbeet]

On 5 August 2016 at 20:56, Matteo Bruni <mbruni(a)codeweavers.com> wrote:
> @@ -32,7 +32,7 @@ HRESULT WINAPI D3DX11CompileFromMemory(const char *data, SIZE_T data_size, const
>  {
>      TRACE("data %s, data_size %lu, filename %s, defines %p, include %p, entry_point %s, target %s, "
>              "sflags %#x, eflags %#x, pump %p, shader %p, error_messages %p, hresult %p.\n",
> -            debugstr_a(data), data_size, debugstr_a(filename), defines, include, entry_point,
> +            debugstr_a(data), data_size, debugstr_a(filename), defines, include, debugstr_a(entry_point),
> Somewhat related, this seems to assume "data" is a zero-terminated string.

[PATCH 1/5] d3dx11: Use debugstr_a() to trace a user-supplied string.

[Matteo Bruni]

2016-08-05 23:14 GMT+02:00 Henri Verbeet <hverbeet(a)gmail.com>:
> On 5 August 2016 at 20:56, Matteo Bruni <mbruni(a)codeweavers.com> wrote:
> > @@ -32,7 +32,7 @@ HRESULT WINAPI D3DX11CompileFromMemory(const char *data, SIZE_T data_size, const
> >  {
> >      TRACE("data %s, data_size %lu, filename %s, defines %p, include %p, entry_point %s, target %s, "
> >              "sflags %#x, eflags %#x, pump %p, shader %p, error_messages %p, hresult %p.\n",
> > -            debugstr_a(data), data_size, debugstr_a(filename), defines, include, entry_point,
> > +            debugstr_a(data), data_size, debugstr_a(filename), defines, include, debugstr_a(entry_point),
> > Somewhat related, this seems to assume "data" is a zero-terminated string.

Right, it should make use of data_size given that it's right there...