Re: ntoskrnl.exe: Implemented IoCreateSymbolicLink

[Vitaliy Margolen]

Alexandre Julliard wrote:
> +    attr.Attributes               = OBJ_CASE_INSENSITIVE | OBJ_OPENIF;
> +    attr.SecurityDescriptor       = NULL;
> +    attr.SecurityQualityOfService = NULL;
> +
> +    TRACE( "%s -> %s\n", debugstr_us(name), debugstr_us(target) );
> +    /* FIXME: store handle somewhere */
> +    return NtCreateSymbolicLinkObject( &handle, SYMBOLIC_LINK_ALL_ACCESS, &attr, target );

How are you planning on removing them if you don't keep a handle to this
symlink? Also why OBJ_CASE_INSENSITIVE? This is kernel, and last time
I've checked NT kernel's name space was case-sensitive.

Vitaliy.

ntoskrnl.exe: Implemented IoCreateSymbolicLink

[Alexandre Julliard]

Vitaliy Margolen <wine-devel(a)kievinfo.com> writes:
> How are you planning on removing them if you don't keep a handle to this
> symlink?

Yes, obviously the handle will need to be stored to remove it, that's
why there's a FIXME. Since it will be removed automatically on driver
unload, it's not the most important thing to implement at this point.
> Also why OBJ_CASE_INSENSITIVE? This is kernel, and last time
> I've checked NT kernel's name space was case-sensitive.

No particular reason, I just copied this from some other object. I
doubt it makes a difference but if you have evidence that it should be
case sensitive here feel free to send a patch.

-- 
Alexandre Julliard
julliard(a)winehq.org