Re: [PATCH 2/2] wpcap: Fix crash on pcap_loop(try 3)

[Alexandre Julliard]

André Hentschel <nerv(a)dawncrow.de> writes:
> Am 12.02.2016 um 06:31 schrieb Jianqiu Zhang:
> > From 12ecf0983d9355e3f1b4781645503cb4fb65e599 Mon Sep 17 00:00:00 2001
> > From: Jianqiu Zhang <zhangjianqiu_133(a)yeah.net>
> > Date: Tue, 5 Jan 2016 09:12:42 +0800
> > Subject: [PATCH 2/2] wpcap: Fix crash on pcap_loop
>
> Signed-off-by: André Hentschel <nerv(a)dawncrow.de>

Was there a reason you didn't use a simple stack variable originally?

-- 
Alexandre Julliard
julliard(a)winehq.org

[PATCH 2/2] wpcap: Fix crash on pcap_loop(try 3)

[André Hentschel]

Am 13.02.2016 um 03:54 schrieb Alexandre Julliard:
> André Hentschel <nerv(a)dawncrow.de> writes:
> > Am 12.02.2016 um 06:31 schrieb Jianqiu Zhang:
> > > From 12ecf0983d9355e3f1b4781645503cb4fb65e599 Mon Sep 17 00:00:00 2001
> > > From: Jianqiu Zhang <zhangjianqiu_133(a)yeah.net>
> > > Date: Tue, 5 Jan 2016 09:12:42 +0800
> > > Subject: [PATCH 2/2] wpcap: Fix crash on pcap_loop
> >
> > Signed-off-by: André Hentschel <nerv(a)dawncrow.de>
>
> Was there a reason you didn't use a simple stack variable originally?

No, I guess that might be an even better idea.

[PATCH 2/2] wpcap: Fix crash on pcap_loop(try 3)

[Jianqiu Zhang]

在 2016-02-14 18:59:15，"André Hentschel" <nerv(a)dawncrow.de> 写道：
> Am 13.02.2016 um 03:54 schrieb Alexandre Julliard:
> > André Hentschel <nerv(a)dawncrow.de> writes:
> > > Am 12.02.2016 um 06:31 schrieb Jianqiu Zhang:
> > > > From 12ecf0983d9355e3f1b4781645503cb4fb65e599 Mon Sep 17 00:00:00 2001
> > > > From: Jianqiu Zhang <zhangjianqiu_133(a)yeah.net>
> > > > Date: Tue, 5 Jan 2016 09:12:42 +0800
> > > > Subject: [PATCH 2/2] wpcap: Fix crash on pcap_loop
> > >
> > > Signed-off-by: André Hentschel <nerv(a)dawncrow.de>
> >
> > Was there a reason you didn't use a simple stack variable originally?
>
> No, I guess that might be an even better idea.

Should I correct this(use stack variable)and send another patch then?

[PATCH 2/2] wpcap: Fix crash on pcap_loop(try 3)

[André Hentschel]

Am 14.02.2016 um 12:06 schrieb Jianqiu Zhang:
> 在 2016-02-14 18:59:15，"André Hentschel" <nerv(a)dawncrow.de> 写道：
> > Am 13.02.2016 um 03:54 schrieb Alexandre Julliard:
> > > André Hentschel <nerv(a)dawncrow.de> writes:
> > > > Am 12.02.2016 um 06:31 schrieb Jianqiu Zhang:
> > > > > From 12ecf0983d9355e3f1b4781645503cb4fb65e599 Mon Sep 17 00:00:00 2001
> > > > > From: Jianqiu Zhang <zhangjianqiu_133(a)yeah.net>
> > > > > Date: Tue, 5 Jan 2016 09:12:42 +0800
> > > > > Subject: [PATCH 2/2] wpcap: Fix crash on pcap_loop
> > > >
> > > > Signed-off-by: André Hentschel <nerv(a)dawncrow.de>
> > >
> > > Was there a reason you didn't use a simple stack variable originally?
> >
> > No, I guess that might be an even better idea.
>
> Should I correct this(use stack variable)and send another patch then?

Yes, please