Re: resources: Convert Polish resources to UTF8.

[Frédéric Delanoy]

Hi.

I see this patch has been "Rejected" in
http://source.winehq.org/patches/, but I just wondered why:
- are the UTF8 resources not preferred over custom codepages?
- or is the patch simply too big to review? Splitting into many tiny
patches seemed a bit overkill for such a simple change, no?

Or maybe is it simply because Polish translations is still in
progress, and it can/will cause conflict?

I'm a bit confused here...

Frédéric

NB: I didn't touch any nls file in this patch so it shouldn't cause
regressions (and had a subset of it tested by Łukasz Wojniłowicz, a
native Polish speaker)

resources: Convert Polish resources to UTF8.

[James McKenzie]

Frédéric Delanoy wrote:
> Hi.
>
> I see this patch has been "Rejected" in
> http://source.winehq.org/patches/,

Could be formatted incorrectly or just basically contain invalid 
information (not incorrect) as the format of the patch does not include 
things like th #pragma line.

However, I have a much better question.  I track the patches to see 
which were applied and which were not.  How can I get OLDER information 
on patches from previous releases?

I'm truly interested in the series of patches that I have submitted and 
would like to get them 'out of the way' so I can move onto other items.

Thank you for minding my interruption and back to the regularly 
scheduled Wine Development.

James McKenzie

resources: Convert Polish resources to UTF8.

[GOUJON Alexandre]

Le 11/06/2010 03:52, James McKenzie a écrit :
> How can I get OLDER information on patches from previous releases? 
> You should have a look at http://www.winehq.org/mailman/listinfo.
> Everything is archived (patches submitted, commits and of course this 
> mailing list)

It's very useful when someone tried to do something before but was 
rejected/incomplete.

resources: Convert Polish resources to UTF8.

[Dmitry Timoshkov]

Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote:
> I see this patch has been "Rejected" in
> http://source.winehq.org/patches/, but I just wondered why:
> - are the UTF8 resources not preferred over custom codepages?
> - or is the patch simply too big to review? Splitting into many tiny
> patches seemed a bit overkill for such a simple change, no?
>
> Or maybe is it simply because Polish translations is still in
> progress, and it can/will cause conflict?

There is no point in just converting the translations. If you update
a translation, and simulataneously convert it - that's OK.

-- 
Dmitry.

resources: Convert Polish resources to UTF8.

[Frédéric Delanoy]

2010/6/11 Dmitry Timoshkov <dmitry(a)codeweavers.com>:
> Frédéric Delanoy <frederic.delanoy(a)gmail.com> wrote:
> > I see this patch has been "Rejected" in
> > http://source.winehq.org/patches/, but I just wondered why:
> > - are the UTF8 resources not preferred over custom codepages?
> > - or is the patch simply too big to review? Splitting into many tiny
> > patches seemed a bit overkill for such a simple change, no?
> >
> > Or maybe is it simply because Polish translations is still in
> > progress, and it can/will cause conflict?
>
> There is no point in just converting the translations. If you update
> a translation, and simulataneously convert it - that's OK.
>
> --
> Dmitry.

Well, I proposed Łukasz to use UTF8 (since it appeared to be the new
standard charset) while he was updating Polish translations, but since
he wasn't too comfortable with the process, I offered to do it myself,
so wrote a script to check/convert files (and he tested the result).

I could give him the script so he can use it when he updates a file,
but I don't see the added value not to do it directly.

I don't see the problem with converting files without updating a
single translation: is it so regression-prone?

Frédéric

resources: Convert Polish resources to UTF8.

[Paul Vriens]

On 06/11/2010 08:38 AM, Frédéric Delanoy wrote:
> 2010/6/11 Dmitry Timoshkov<dmitry(a)codeweavers.com>:
> > Frédéric Delanoy<frederic.delanoy(a)gmail.com>  wrote:
> > > I see this patch has been "Rejected" in
> > > http://source.winehq.org/patches/, but I just wondered why:
> > > - are the UTF8 resources not preferred over custom codepages?
> > > - or is the patch simply too big to review? Splitting into many tiny
> > > patches seemed a bit overkill for such a simple change, no?
> > >
> > > Or maybe is it simply because Polish translations is still in
> > > progress, and it can/will cause conflict?
> >
> > There is no point in just converting the translations. If you update
> > a translation, and simulataneously convert it - that's OK.
> >
> > --
> > Dmitry.
>
> Well, I proposed Łukasz to use UTF8 (since it appeared to be the new
> standard charset) while he was updating Polish translations, but since
> he wasn't too comfortable with the process, I offered to do it myself,
> so wrote a script to check/convert files (and he tested the result).
>
> I could give him the script so he can use it when he updates a file,
> but I don't see the added value not to do it directly.
>
> I don't see the problem with converting files without updating a
> single translation: is it so regression-prone?
>
> Frédéric

I talked to Alexandre about this the other day and he also said that we 
shouldn't convert the existing files to UTF-8.

Post 1.2 we would most likely go with po files for the translations 
themselves and at that point everything would become UTF-8.

-- 
Cheers,

Paul.