Re: gdiplus: Reuse an existing image stream in GdipImageSelectActiveFrame.
27 Sep
2012
27 Sep
'12
9:52 a.m.
@@ -3898,7 +3894,7 @@ GpStatus WINGDIPAPI GdipImageSelectActiveFrame(GpImage *image, GDIPCONST GUID *d return Ok; }
- IStream_Release(stream); + IStream_Release(image->stream); return stat; }
I don't think it's necessary to AddRef/Release the stream anymore in GdipImageSelectActiveFrame. Creating the new image and freeing the old one will update the refcount as necessary. And it's a bit confusing since technically the current image->stream is released by free_image_data then overwritten (with the same value, fortunately) by copying new_image to image. Looks good otherwise.
4823
Age (days ago)
4823
Last active (days ago)
0 comments
1 participants
participants (1)
-
Vincent Povirk