October 2022 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR1184: user32: Fix rounding issue in edit tests for char pos messages.
by eric pouech (＠epo) 29 Oct '22

29 Oct '22

- the tests were failing in Hindi/UTF8 - rounding with (lo+(hi-lo+1)/2) let all the tests pass - rounding with (lo+(hi-lo)/2 + 1) (as it's done when ES_MULTILINE is enabled) let the Hindi/UTF8 fail - it looked weird to have different rounding computation in single vs multi line - so, changing all rounding to (lo+(hi-lo+1)/2) let all the tests pass Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1184

2 1

[PATCH 0/1] MR1183: d2d1: Update to ID2D1Device1.
by Vladislav Timonin (＠vt) 29 Oct '22

29 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1183

3 6

[PATCH v6 0/2] MR914: ntoskrnl.exe: Implement various KeQuery* functions
by Etaash Mathamsetty (＠etaash.mathamsetty) 29 Oct '22

29 Oct '22

mrac tries to get function pointers for these functions using MmGetSystemRoutineAddress, I haven't seen them being used by it, but might as well implement it since they are very easy to implement. -- v6: ntoskrnl.exe: Implement KeQueryActiveProcessorCount. ntoskrnl.exe: implement KeQueryMaximumProcessorCount/Ex. https://gitlab.winehq.org/wine/wine/-/merge_requests/914

2 2

[PATCH v5 0/2] MR914: ntoskrnl.exe: Implement various KeQuery* functions
by Etaash Mathamsetty (＠etaash.mathamsetty) 29 Oct '22

29 Oct '22

mrac tries to get function pointers for these functions using MmGetSystemRoutineAddress, I haven't seen them being used by it, but might as well implement it since they are very easy to implement. -- v5: ntoskrnl.exe: implement KeQueryMaximumProcessorCount/Ex. ntoskrnl.exe: implement KeQueryActiveProcessorCount. https://gitlab.winehq.org/wine/wine/-/merge_requests/914

3 3

[PATCH v12 0/3] MR1164: gdiplus: add initial CompoundLine support to fix application crash
by Bartosz Kosiorek (＠gang65) 29 Oct '22

29 Oct '22

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=52196 -- v12: gdiplus: add GdipGetPenCompoundArray implementation gdiplus: add GdipGetPenCompoundCount implementation gdiplus: add GdipSetPenCompoundArray implementation https://gitlab.winehq.org/wine/wine/-/merge_requests/1164

3 5

[PATCH v11 0/3] MR1164: Draft: gdiplus: add initial CompoundLine support to fix application crash
by Bartosz Kosiorek (＠gang65) 29 Oct '22

29 Oct '22

Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=52196 -- v11: gdiplus: add GdipGetPenCompoundArray implementation gdiplus: add GdipGetPenCompoundCount implementation gdiplus: add GdipSetPenCompoundArray implementation https://gitlab.winehq.org/wine/wine/-/merge_requests/1164

4 11

[PATCH v6 0/5] MR741: ntdll: Implement NtFlushProcessWriteBuffers.
by Torge Matthies (＠tmatthies) 28 Oct '22

28 Oct '22

Based on [a patch](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.… by Jinoh Kang (@iamahuman) from February 2022. I removed the need for the event object and implemented fast paths for Linux. On macOS 10.14+ `thread_get_register_pointer_values` is used on every thread of the process. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_GLOBAL_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 `madvise(..., MADV_DONTNEED)` is used, which sends IPIs to all cores causing them to do a memory barrier. On non-x86 Linux <= 4.2 and on other platforms the fallback path using APCs is used. -- v6: ntdll: Add thread_get_register_pointer_values-based fast path for NtFlushProcessWriteBuffers. ntdll: Add sys_membarrier-based fast path to NtFlushProcessWriteBuffers. ntdll: Add MADV_DONTNEED-based fast path for NtFlushProcessWriteBuffers. ntdll: Make server_select a memory barrier. ntdll: Implement NtFlushProcessWriteBuffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/741

5 11

[PATCH v5 0/7] MR1111: winsock: Always use Unix SO_REUSEADDR on TCP sockets.
by Paul Gofman (＠gofman) 28 Oct '22

28 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50955 The problem which this patchset aims to solve is (sometimes) huge timeout on TCP listening port availability on Linux after the listening socket was closed one or another way. By default, the listening port will also be blocked for the whole time accepted socket waits through lengthy timeouts (sometimes; most surely when the listening process with an active connection was force killed, but not limited to this condition). BSD SO_REUSEADDR socket option is aimed mainly to avoid that extra wait on binding already closed listening socket address. From [1]: "Indicates that the rules used in validating addresses supplied in a bind(2) call should allow reuse of local addresses. For AF_INET sockets this means that a socket may bind, except when there is an active listening socket bound to the address.". Unix SO_REUSEADDR does not really allow reusing address in the Winsock sense. It will just allow to ditch the timeout (which is always the case on Windows without any specific options). Unfortunately it is not the only effect of the option. It still won't allow listening on the address simultaneously (unlike Winsock SO_REUSEADDR which allows simultaneous listening), or binding to an address which is being listened. But it will allow to bind different sockets for the same address which is not the Winsock behaviour when Winsock SO_REUSEADDR is set. So the patchset enables SO_REUSEADDR on every TCP socket and introduces the bound address tracking which will allow to return an error from bind() when needed. Not related to this patchset, but Winsock SO_REUSEADDR is somewhat closer to BSD SO_REUSEPORT, although is different in a way that _REUSEPORT will load balance connections between listeners while with Winsock _REUSEADDR the connections will always go to the first listener. I hope that the bound addresses tracking introduced in these patches may be reused in the future. E. g., maybe it might be helpful on the way of implementing the todos introduced by my extended tests (those todos are not related to this patchset and exist both with and without it). 1. https://man7.org/linux/man-pages/man7/socket.7.html -- v5: ws2_32/tests: Also test bind to any together with loopback in a different order. https://gitlab.winehq.org/wine/wine/-/merge_requests/1111

3 10

Re: [PATCH 0/1] MR111: Draft: winedbg: Allow loading 32bit module symbols in a 64bit debuggee process from winedbg's --gdb mode. - approved
by Zebediah Figura (＠zfigura) 28 Oct '22

28 Oct '22

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/111

1 0

[PATCH 0/6] MR1111: winsock: Always use Unix SO_REUSEADDR on TCP sockets.
by Paul Gofman (＠gofman) 28 Oct '22

28 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50955 The problem which this patchset aims to solve is (sometimes) huge timeout on TCP listening port availability on Linux after the listening socket was closed one or another way. By default, the listening port will also be blocked for the whole time accepted socket waits through lengthy timeouts (sometimes; most surely when the listening process with an active connection was force killed, but not limited to this condition). BSD SO_REUSEADDR socket option is aimed mainly to avoid that extra wait on binding already closed listening socket address. From [1]: "Indicates that the rules used in validating addresses supplied in a bind(2) call should allow reuse of local addresses. For AF_INET sockets this means that a socket may bind, except when there is an active listening socket bound to the address.". Unix SO_REUSEADDR does not really allow reusing address in the Winsock sense. It will just allow to ditch the timeout (which is always the case on Windows without any specific options). Unfortunately it is not the only effect of the option. It still won't allow listening on the address simultaneously (unlike Winsock SO_REUSEADDR which allows simultaneous listening), or binding to an address which is being listened. But it will allow to bind different sockets for the same address which is not the Winsock behaviour when Winsock SO_REUSEADDR is set. So the patchset enables SO_REUSEADDR on every TCP socket and introduces the bound address tracking which will allow to return an error from bind() when needed. Not related to this patchset, but Winsock SO_REUSEADDR is somewhat closer to BSD SO_REUSEPORT, although is different in a way that _REUSEPORT will load balance connections between listeners while with Winsock _REUSEADDR the connections will always go to the first listener. I hope that the bound addresses tracking introduced in these patches may be reused in the future. E. g., maybe it might be helpful on the way of implementing the todos introduced by my extended tests (those todos are not related to this patchset and exist both with and without it). 1. https://man7.org/linux/man-pages/man7/socket.7.html -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1111

6 28